Dynamic Parameters Only validating params that are part of the plugin #5106

Nils-ChristianIseke · 2025-04-25T15:09:47Z

Fixing a bug introduced in #4971.
Should fix #5100.

Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com>

ajtudela · 2025-04-25T15:12:21Z

This PR addresses this issue, right?

Nils-ChristianIseke · 2025-04-25T15:17:58Z

This PR addresses this issue, right?

Yes. I haven't tested it yet! Will hopefully do so tomorrow. If you have time to test it i would appreciate it :).

ajtudela · 2025-04-25T15:46:58Z

This PR addresses this issue, right?

Yes. I haven't tested it yet! Will hopefully do so tomorrow. If you have time to test it i would appreciate it :).

Sorry, I'll be out of the lab until Monday.

codecov · 2025-04-25T16:44:09Z

Codecov Report

Attention: Patch coverage is 99.08815% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
nav2_amcl/src/amcl_node.cpp	0.00%	1 Missing ⚠️
nav2_smac_planner/src/smac_planner_hybrid.cpp	96.96%	1 Missing ⚠️
nav2_smac_planner/src/smac_planner_lattice.cpp	96.55%	1 Missing ⚠️

Files with missing lines	Coverage Δ
nav2_collision_monitor/src/polygon.cpp	`97.41% <100.00%> (+<0.01%)`	⬆️
nav2_collision_monitor/src/source.cpp	`98.30% <100.00%> (+0.02%)`	⬆️
nav2_controller/plugins/pose_progress_checker.cpp	`96.77% <100.00%> (+0.10%)`	⬆️
nav2_controller/plugins/simple_goal_checker.cpp	`100.00% <100.00%> (ø)`
...av2_controller/plugins/simple_progress_checker.cpp	`100.00% <100.00%> (ø)`
nav2_controller/plugins/stopped_goal_checker.cpp	`100.00% <100.00%> (ø)`
nav2_controller/src/controller_server.cpp	`85.53% <100.00%> (-0.08%)`	⬇️
nav2_costmap_2d/plugins/inflation_layer.cpp	`99.51% <100.00%> (+<0.01%)`	⬆️
nav2_costmap_2d/plugins/obstacle_layer.cpp	`81.87% <100.00%> (+0.05%)`	⬆️
nav2_costmap_2d/plugins/plugin_container_layer.cpp	`98.83% <100.00%> (+0.01%)`	⬆️
... and 21 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nav2_regulated_pure_pursuit_controller/src/parameter_handler.cpp

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

SteveMacenski · 2025-05-12T19:43:47Z

@Nils-ChristianIseke approved - can you do this for all controllers and planners?

Nils-ChristianIseke · 2025-05-14T10:18:32Z

@SteveMacenski do you want me to do this in this PR?

SteveMacenski · 2025-05-14T20:35:30Z

Yes please - so we resolve the scope of the ticket. I think there's one callout that should also be made: controller_frequency. This is sometimes used in the controllers and obtained by the main Controller Server which is dynamically reconfigurable. If this parameter is changed, then I think we should trigger the update as well. Its used in virtually all of the controllers (DWB, MPPI, RPP, Rotation Shim). it actually looks like RPP needs to have controller_frequency checked and updated in the dynamic parameter callback. Right now it doesn't update.

The other option would be to remove this as a dynamic parameter option so its cannot be updated. Which... seems reasonable.

I didn't see any shared Planner Server x Planner Plugin parameter overlap, but please check to make sure I didn't miss anything :-)

… consistency. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

SteveMacenski

What about MPPI?

Overall looks good, I want this in for Kilted release so I'm going to block forking Kilted until we can get this in, I think its important. Thanks for this great work!

nav2_controller/plugins/simple_goal_checker.cpp

nav2_theta_star_planner/src/theta_star_planner.cpp

nav2_smac_planner/src/smac_planner_lattice.cpp

nav2_smac_planner/src/smac_planner_hybrid.cpp

nav2_smac_planner/src/smac_planner_2d.cpp

nav2_navfn_planner/src/navfn_planner.cpp

nav2_planner/src/planner_server.cpp

nav2_docking/opennav_docking/src/controller.cpp

nav2_costmap_2d/src/costmap_2d_ros.cpp

Nils-ChristianIseke · 2025-05-16T07:23:57Z

@SteveMacenski you are too quick with your reviews ;). I will ping you as soon this one is review ready :). Will hopefully find some time today to finish it!

mergify · 2025-05-16T18:00:08Z

This pull request is in conflict. Could you fix it @Nils-ChristianIseke?

SteveMacenski · 2025-05-16T18:06:05Z

OK :-) Let me know

This reverts commit a0a7892. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Nils-ChristianIseke · 2025-05-20T20:18:54Z

@SteveMacenski I think i need some feedback regarding the changes necessary to nav2_mppi_controller. Could you have a look at 15ed1c9? Not sure if i am heading in the right direction there. No nee to get feedback on formatting issues or failing test (as this is WIP), Just on the general approach.

SteveMacenski · 2025-05-21T00:02:47Z

I think it would be good to have a bool if any callback is triggered. If so, then we run the post callbacks (which triggers the reset()). If not, then we don't. As written, this would still trigger reset() even if every parameter update is not related to MPPI.

auto getParentParam = parameters_handler_->getParamGetter("test");

Obvously this shouldn't be test in optimizer.cpp, but I think you know this one. Generally looks good to me - did you have any particular concern I should focus in on?

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

… updated. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com>

Nils-ChristianIseke · 2025-05-21T10:48:08Z

@SteveMacenski ci/circleci: release_test fails a bit random. I don't get why it failed for 9e2655b and 5eea8e7. Espacially 5eea8e7 was just adding an empty line.

SteveMacenski · 2025-05-21T17:47:50Z

It looks to be a little flaky, something happened in the last ~2 weeks or so that introduced flakiness. I suspect some regressions in rclcpp from the rush to get out Kilted (or hey, could be me too!) but I haven't had the cycles yet to investigate. I retriggered and expect it to pass.

SteveMacenski

A couple of small cleanups but LGTM!

nav2_mppi_controller/include/nav2_mppi_controller/tools/parameters_handler.hpp

nav2_mppi_controller/src/parameters_handler.cpp

nav2_docking/opennav_docking/src/docking_server.cpp

nav2_docking/opennav_docking/test/test_docking_server_unit.cpp

nav2_controller/src/controller_server.cpp

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

nav2_mppi_controller/src/parameters_handler.cpp

SteveMacenski · 2025-05-22T17:30:53Z

nav2_mppi_controller/src/parameters_handler.cpp

+        callback->second(param, result);
+      }
+    }
+    for (auto & post_cb : post_callbacks_) {


Suggested change

for (auto & post_cb : post_callbacks_) {

for (auto & post_cb : post_callbacks_) {

@SteveMacenski I'm just checking the rule here, do you want an empty line before each if, for, while statement? We could force this via uncrustify's configuration, I can create a PR for that if you'd like.

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

SteveMacenski · 2025-05-22T17:34:20Z

Docs ros-navigation/docs.nav2.org#699

nav2_mppi_controller/test/parameter_handler_test.cpp

…ros-navigation#5106) * Only validating params that are part of the plugin Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * review Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Refactoring type with param_type and name with param_name to get more consistency. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Check if plugin_name is part of param_name Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Check if param_name contains name_ Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Add check param name in dynamic parameter upate. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Remove controller_frequency as dynamic parameter Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "Merge remote-tracking branch 'origin/main' into FixNamespaceCheck" This reverts commit 7632e41, reversing changes made to 19afc9e. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix merge errors. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Add missing check to simple_goal_checker Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Handel param_name resolution for smac_planner_hybrid Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix typo Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "uncrustify" This reverts commit 43749c2. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "uncrustify" This reverts commit e18f704. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "fix" This reverts commit a0a7892. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * MPPI Check Namespace. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fixing parameter_handler tests. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix optimizer Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix indentation Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * mppi param handler only execute post_callbacks if a param of mppi was updated. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update nav2_rotation_shim_controller.hpp Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> * Review Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

…#5106) * Only validating params that are part of the plugin Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * review Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Refactoring type with param_type and name with param_name to get more consistency. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Check if plugin_name is part of param_name Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Check if param_name contains name_ Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Add check param name in dynamic parameter upate. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Remove controller_frequency as dynamic parameter Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "Merge remote-tracking branch 'origin/main' into FixNamespaceCheck" This reverts commit 7632e41, reversing changes made to 19afc9e. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix merge errors. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Add missing check to simple_goal_checker Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Handel param_name resolution for smac_planner_hybrid Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix typo Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "uncrustify" This reverts commit 43749c2. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "uncrustify" This reverts commit e18f704. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "fix" This reverts commit a0a7892. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * MPPI Check Namespace. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fixing parameter_handler tests. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix optimizer Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix indentation Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * mppi param handler only execute post_callbacks if a param of mppi was updated. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update nav2_rotation_shim_controller.hpp Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> * Review Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Add speed filter zones to depot and warehouse maps. (#5146) * Added keepout prefix to keepout zone related params. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Add namespace support for speed filter zones. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added speed filter zones to depot and warehouse maps. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added dedicated launch file for speed zone support. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Updated rviz2 config to include speed zone filter. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Preserve initial nature of costmap filters tests. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Enable namespace for the speed limit topic. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Update speed filter zones in depot and warehouse maps Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Readjust speed filter zones in depot and warehouse maps. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Enable namespace support for speed limit topic. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Reduced central speed zone in warehouse map. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * suppress rviz logging to warnings and above (#5163) * suppress rviz to warnings and above Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_bringup/launch/rviz_launch.py Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding Jazzy build job on Main PRs to automatically test Jazzy compatiblity long term (Kilted to come shortly) (#5164) * Adding jazzy testing job Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * on PR not push Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * move dir Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * more Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * moar Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * moar Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * more Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fin Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Prevent MPPI controller from resetting speed limits upon goal execution. (#5165) Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Backward docking without sensors (#5153) * Merge remote-tracking branch 'jakub/backward-docking-without-sensors' into docking_backward Signed-off-by: Jakubach <jakubach@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor fixes and update controller test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add more tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Move backward_plugin param to plugin Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fixed rotateToDock and tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update readme Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added rotate_to_dock_timeout Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Use angular acceleration te acelerate / decelerate Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added mutex Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix exception Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Revert "Added mutex" This reverts commit 29ff010. Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Rename rotate_to_dock Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Rotate after undock and fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Log after rotation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Jakubach <jakubach@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Speed up CI builds for released distros (#5168) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Save 2 minutes in Main-Jazzy build times to align with other CI job lengths (#5169) * Save 2 minutes in Main-Jazzy build times to align with other CI job lengths Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update build_main_against_distros.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update build_main_against_distros.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Fixing docking server when already docked at the requeste ddock (#5171) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update mergify.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fix MPPI goal critic inversion (#5088) (#5105) * fix MPPI goal critic inversion (#5088) Signed-off-by: brayanpa <brayanspallares@gmail.com> * Support path inversion in all critics (#5088) Signed-off-by: brayanpa <brayanspallares@gmail.com> * Fix code style issues and formatting Signed-off-by: brayanpa <brayanspallares@gmail.com> * Remove trailing whitespaces Signed-off-by: brayanpa <brayanspallares@gmail.com> * Fix goalAngleCritic tests Signed-off-by: brayanpa <brayanspallares@gmail.com> * Normalize code formatting Signed-off-by: brayanpa <brayanspallares@gmail.com> * Add getLastPathPose test Signed-off-by: brayanpa <brayanspallares@gmail.com> * Abstract getCriticGoal in nav2_mppi critics Signed-off-by: brayanpa <brayanspallares@gmail.com> * Fix whitespace issues Signed-off-by: brayanpa <brayanspallares@gmail.com> * Fix getCriticGoal test Signed-off-by: brayanpa <brayanspallares@gmail.com> --------- Signed-off-by: brayanpa <brayanspallares@gmail.com> Signed-off-by: Brayan Pallares <brayanspallares@gmail.com> * Add stateful to regulated pure pursuit controller (#5167) * add_stateful_to_regulated_pure_pursuit_controller Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * fix naming Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * fix naming left over Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * resolve comments Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * typo Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * add unit test for both cases stateful and not stateful Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> --------- Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * tf2 uses hpp headers in rolling (and is backported) (#5180) Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> * added config for laserscan in lb-sim (#5174) * added config for laserscan in lb-sim Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * fixing ament_flake8 errors Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * review: use_inf is default:true and added parameters on readme #4992 Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * refactor: meaningfull value for scan_angle_increment Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> --------- Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> Co-authored-by: RamanaBotta <ramanab@bosonmotors.com> * Publish planned footprints after smoothing (#5155) * Publish planned footprints after smoothing Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Revert "Publish planned footprints after smoothing" This reverts commit c9b349a. * Add smoothed footprints publishing Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix formatting Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Fix indentation for publisher creation in SmacPlannerHybrid and SmacPlannerLattice Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * address PR comments Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fixes Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix build error Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fixing deprecation warning (#5182) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Removing action server timeout duration after fixes to ROS 2, Reverts 3787 (#5183) * Removing action server timeout duration after fixes to ROS 2 Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fix build warning Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * action timeout in BT client edits error code and string (#5184) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Dynamic Parameters Only validating params that are part of the plugin (#5106) * Only validating params that are part of the plugin Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * review Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Refactoring type with param_type and name with param_name to get more consistency. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Check if plugin_name is part of param_name Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Check if param_name contains name_ Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Add check param name in dynamic parameter upate. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Remove controller_frequency as dynamic parameter Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "Merge remote-tracking branch 'origin/main' into FixNamespaceCheck" This reverts commit 7632e41, reversing changes made to 19afc9e. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix merge errors. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Add missing check to simple_goal_checker Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Handel param_name resolution for smac_planner_hybrid Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix typo Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "uncrustify" This reverts commit 43749c2. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "uncrustify" This reverts commit e18f704. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "fix" This reverts commit a0a7892. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * MPPI Check Namespace. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fixing parameter_handler tests. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix optimizer Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix indentation Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * mppi param handler only execute post_callbacks if a param of mppi was updated. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update nav2_rotation_shim_controller.hpp Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> * Review Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Increase Readability of testing. (#5190) Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Add value rewrites to RewrittenYaml (#5191) * Added context manager for safe file closing and prevent warnings. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Implement value_rewrites to ReWrittenYaml. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Use placeholders for costmap filters using the new value rewrite feature. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Enable system tests to use value rewrites. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Define remappings for costmap filters instead of inline substitution. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Updates for Kilted Branch off (#5199) * Adding kilted build to main branch workflow Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Updating kilted for ci image build Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Bumping to 1.4.0 for kilted release Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Removing underlay workspace from Main (#5200) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding missing dep to loopback sim (#5204) * Adding missing dep Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * typo Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * updating fix Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding parameter warn_when_defaulting_parameters to control default parameter warnings (#5189) * Adding a parameter warn_when_defaulting_parameters to control default parameter warnings instead of using a flag Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Adding parameter strict_param_loading for optionally throwing an exception if parameter overrides are missing Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Using default false declaration instead of declare_or_get in param util Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> --------- Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Update mergify.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * include bug fix for nav2_smac_planner (#5198) Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Revert "Removing underlay workspace from Main" (#5206) * Revert "Removing underlay workspace from Main (#5200)" This reverts commit 1278df7. * Update underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Option to Reduce Lethal to High-Cost Navigable To Get Out of Keepout Zones if Wandered In (#5187) * Adding toggle option of keepout zone Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Default off Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Join conditions Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * spell check Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * copilot suggestions Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update keepout_filter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Prototype solving #5192 Issue 2: Reeds-Shepp reduce small reverse expansions (#5207) * prototype solving 5192 issue 2 Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Removing unnecessary variable Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Revert recent smac changes causing regressions (#5221) * Revert "Prototype solving #5192 Issue 2: Reeds-Shepp reduce small reverse expansions (#5207)" This reverts commit c32873d. * Revert "include bug fix for nav2_smac_planner (#5198)" This reverts commit 6a74ba6. * Revert "Feat/smac planner include orientation flexibility (#4127)" This reverts commit f5543c3. * Disable costmap filter zones from tb3 bringup (only Tb4 enabled) (#5223) * Update tb3_loopback_simulation_launch.py Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update tb3_simulation_launch.py Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Revert "Fix Ci from key signing (#5220)" (#5237) * Revert "Fix Ci from key signing (#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update Cache Version Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Updating readme table for kilted release (#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Updating table lint Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * typo Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Route server corner smoothing (#5226) * added edge length method Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Added corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced double vectors with Coordinates, added methods to return start and end coordinates Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using Coordinates, fixed direction of tangents Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added corner arc in header, added logger in protected variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * first pass of corner smoothing algorithm Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * reassigning next edge to have a different start, if a corner occurs before it Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using unique pointer instead of raw pointers for new edges and nodes Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * made angle of interpolation a parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * const for return methods, added flag for smoothing corners Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * moved getEdgeLength() into the Directional Edge struct Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using float instead of double Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * smoothing radius is float, couple methods moved to protected Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed signed_angle_ as a member variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed unnecessary member variables Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed angle of interpolation and inferring it from path density and radius instead Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * consolidated corner arc into one header function Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * readded newline Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed corner arc to corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced the use of edges with coordinates to generate smoothing arc, removed storage of nodes and edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * fixing cpplint Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting for headers Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpplinting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fixed divide by zeros and accessing empty route.edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * uncrustify linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpp linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * path converter linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed all doubles to floats Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added check for edges that are colinear to avoid divide by 0, fixed final edge interpolation Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * added doxygen for corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added warning message if corner can't be smoothed Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smooth_corners to the nav2 params file Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing flag and radius parameter to README.md' Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * typo in README Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added testing for corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Conserve curvature with LIMIT action (#5255) * Conserve curvature with LIMIT action Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix format Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix test Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Parametrizing obstacle layer tf filter tolerance (#5261) Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Add namespace support for rviz costmap cost tool (#5268) Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com> * Fix/smac planner orientation goals (#5235) * cherry pick Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * cherry pick 6a74ba6 Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * cherrpy pick Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * include x11 forwarding Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * kind of working version Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * cleanup Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * formatting Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * minor format change Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * change naming Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * minor changes Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * working with new changes Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Revert "Fix Ci from key signing (#5220)" (#5237) * Revert "Fix Ci from key signing (#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update Cache Version Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Revert back Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * enable_groot_monitoring_ false (#5246) Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Updating readme table for kilted release (#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Updating table lint Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * typo Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Change max_cost default to 254 (#5256) Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * linter Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * remove const Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * pass const pointer by value Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * pass const pointer by value Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * remove unused param Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> --------- Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> * Increase cache Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fixes for humble main compatibility Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Revert "Removing action server timeout duration after fixes to ROS 2, Reverts 3787 (#5183)" This reverts commit c9438b4. * fixing CI build Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * revert Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * done Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Jakubach <jakubach@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> Signed-off-by: brayanpa <brayanspallares@gmail.com> Signed-off-by: Brayan Pallares <brayanspallares@gmail.com> Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Co-authored-by: Alberto Tudela <ajtudela@gmail.com> Co-authored-by: Brayan Pallares <brayanspallares@gmail.com> Co-authored-by: Jad Haj Mustafa <jado-91@hotmail.com> Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl> Co-authored-by: Raman <52356167+RamanRobotics@users.noreply.github.com> Co-authored-by: RamanaBotta <ramanab@bosonmotors.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Co-authored-by: Marco Bassa <101661130+MarcoMatteoBassa@users.noreply.github.com> Co-authored-by: Stevedan Ogochukwu Omodolor <61468301+stevedanomodolor@users.noreply.github.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: alexanderjyuen <103065090+alexanderjyuen@users.noreply.github.com> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com>

Only validating params that are part of the plugin

8cd8ca4

Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com>

Nils-ChristianIseke force-pushed the FixNamespaceCheck branch from a05d10c to 8cd8ca4 Compare April 25, 2025 15:11

Nils-ChristianIseke mentioned this pull request Apr 25, 2025

Bug in parameter configuration in controller. #5100

Closed

Nils-ChristianIseke marked this pull request as draft April 25, 2025 15:20

Nils-ChristianIseke changed the title ~~Only validating params that are part of the plugin~~ Nac2 regulated_pure_pursuit_controller Only validating params that are part of the plugin Apr 25, 2025

Nils-ChristianIseke changed the title ~~Nac2 regulated_pure_pursuit_controller Only validating params that are part of the plugin~~ nav2_regulated_pure_pursuit_controller: Only validating params that are part of the plugin Apr 25, 2025

SteveMacenski requested changes Apr 28, 2025

View reviewed changes

nav2_regulated_pure_pursuit_controller/src/parameter_handler.cpp Outdated Show resolved Hide resolved

review

3985c95

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Nils-ChristianIseke force-pushed the FixNamespaceCheck branch from be944c7 to 3985c95 Compare May 12, 2025 11:43

Nils-ChristianIseke marked this pull request as ready for review May 12, 2025 11:45

Nils-ChristianIseke requested a review from SteveMacenski May 12, 2025 11:45

SteveMacenski approved these changes May 12, 2025

View reviewed changes

Nils-ChristianIseke changed the title ~~nav2_regulated_pure_pursuit_controller: Only validating params that are part of the plugin~~ Dynamic Parameters Only validating params that are part of the plugin May 15, 2025

Nils-ChristianIseke added 4 commits May 15, 2025 11:09

Refactoring type with param_type and name with param_name to get more…

121466b

… consistency. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Check if plugin_name is part of param_name

1ca16a4

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Check if param_name contains name_

f03c24e

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Uncrustify

2981479

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Nils-ChristianIseke marked this pull request as draft May 15, 2025 11:19

SteveMacenski requested changes May 15, 2025

View reviewed changes

SteveMacenski added the kilted-release label May 16, 2025

Nils-ChristianIseke added 4 commits May 20, 2025 13:21

Revert "fix"

aa5b00a

This reverts commit a0a7892. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck

10fbc3a

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Merge remote-tracking branch 'upstream' into FixNamespaceCheck

b6bbcdf

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

MPPI Check Namespace.

15ed1c9

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Nils-ChristianIseke and others added 5 commits May 21, 2025 07:29

fixing parameter_handler tests.

8331f2f

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Fix optimizer

9e2655b

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Fix indentation

acc41da

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

mppi param handler only execute post_callbacks if a param of mppi was…

dad23f5

… updated. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Update nav2_rotation_shim_controller.hpp

5eea8e7

Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com>

Nils-ChristianIseke marked this pull request as ready for review May 21, 2025 10:48

Nils-ChristianIseke requested a review from SteveMacenski May 21, 2025 10:48

SteveMacenski reviewed May 21, 2025

View reviewed changes

Review

b52f0b1

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

Nils-ChristianIseke requested a review from SteveMacenski May 22, 2025 08:59

SteveMacenski approved these changes May 22, 2025

View reviewed changes

SteveMacenski added 3 commits May 22, 2025 10:31

Update nav2_mppi_controller/src/parameters_handler.cpp

9f5534f

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

Update nav2_mppi_controller/src/parameters_handler.cpp

47e72b4

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

Update nav2_mppi_controller/src/parameters_handler.cpp

b9c37b9

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

SteveMacenski merged commit 7436bbe into ros-navigation:main May 22, 2025
11 of 12 checks passed

Nils-ChristianIseke commented May 23, 2025

View reviewed changes

nav2_mppi_controller/test/parameter_handler_test.cpp Show resolved Hide resolved

RBT22 mentioned this pull request Sep 12, 2025

Jazzy sync 1 2025 Oct 29 EnjoyRobotics/navigation2#61

Open

mini-1235 mentioned this pull request Oct 22, 2025

[Jazzy] [Controller server] Loading multiple controllers at the same time can result in parameter loading issue #5638

Open

	for (auto & post_cb : post_callbacks_) {

	for (auto & post_cb : post_callbacks_) {

Dynamic Parameters Only validating params that are part of the plugin #5106

Dynamic Parameters Only validating params that are part of the plugin #5106

Uh oh!

Conversation

Nils-ChristianIseke commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ajtudela commented Apr 25, 2025

Uh oh!

Nils-ChristianIseke commented Apr 25, 2025

Uh oh!

ajtudela commented Apr 25, 2025

Uh oh!

codecov bot commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

SteveMacenski commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nils-ChristianIseke commented May 14, 2025

Uh oh!

SteveMacenski commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveMacenski left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nils-ChristianIseke commented May 16, 2025

Uh oh!

mergify bot commented May 16, 2025

Uh oh!

SteveMacenski commented May 16, 2025

Uh oh!

Nils-ChristianIseke commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveMacenski commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nils-ChristianIseke commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveMacenski commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveMacenski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SteveMacenski May 22, 2025

Choose a reason for hiding this comment

Uh oh!

Nils-ChristianIseke May 26, 2025

Choose a reason for hiding this comment

Uh oh!

SteveMacenski commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Nils-ChristianIseke commented Apr 25, 2025 •

edited

Loading

codecov bot commented Apr 25, 2025 •

edited

Loading

SteveMacenski commented May 12, 2025 •

edited

Loading

SteveMacenski commented May 14, 2025 •

edited

Loading

SteveMacenski left a comment •

edited

Loading

Nils-ChristianIseke commented May 20, 2025 •

edited

Loading

SteveMacenski commented May 21, 2025 •

edited

Loading

Nils-ChristianIseke commented May 21, 2025 •

edited

Loading

SteveMacenski commented May 21, 2025 •

edited

Loading