Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Removed all occurances of goal_time and enabled linting for benchmarks #23265

Merged
merged 4 commits into from
Oct 23, 2018
Merged

CLN: Removed all occurances of goal_time and enabled linting for benchmarks #23265

merged 4 commits into from
Oct 23, 2018

Conversation

eriknil
Copy link
Contributor

@eriknil eriknil commented Oct 21, 2018

The following changes were made:

  • All occurances of goal_time have been removed. Running grep -rnw asv_bench/benchmarks/ -e goal_time --include "*.py" should no longer return anything.
  • The benchmark folder is no longer excluded in setup.cfg
  • Removed one unused import in asv_bench/benchmarks/io/excel.py to pass flake8.

@pep8speaks
Copy link

Hello @eriknil! Thanks for submitting the PR.

@eriknil eriknil changed the title Removed all occurances of goal_time and enabled linting for benchmarks CLN: Removed all occurances of goal_time and enabled linting for benchmarks Oct 21, 2018
@WillAyd WillAyd added Clean Benchmark Performance (ASV) benchmarks labels Oct 22, 2018
WillAyd
WillAyd approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @datapythonista

doc/source/whatsnew/v0.24.0.txt Outdated
@@ -203,6 +203,7 @@ Other Enhancements
- :meth:`Index.to_frame` now supports overriding column name(s) (:issue:`22580`).
- New attribute :attr:`__git_version__` will return git commit sha of current build (:issue:`21295`).
- Compatibility with Matplotlib 3.0 (:issue:`22790`).
- Asv benchmarks are no longer excluded when running flake8 and occurrences of the benchmark directive `goal_time` has been removed. (:issue:`23075`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically internal cleanups don't need a whatsnew, though I'm not against this as is

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea this can be removed

@jreback jreback added this to the 0.24.0 milestone Oct 23, 2018
@jreback jreback merged commit 7bcba9c into pandas-dev:master Oct 23, 2018
@jreback
Copy link
Contributor

jreback commented Oct 23, 2018

thanks @eriknil

jorisvandenbossche added a commit that referenced this pull request Oct 23, 2018
@jorisvandenbossche
Revert "CLN: Removed all occurances of goal_time and enabled lintin…
bb36315 
…g for benchmarks (#23265)"

This reverts commit 7bcba9c.
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Oct 23, 2018
@eriknil @JustinZhengBC
CLN: Removed all occurances of goal_time and enabled linting for be…
b6ee147 
…nchmarks (pandas-dev#23265)
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@eriknil @tm9k1
CLN: Removed all occurances of goal_time and enabled linting for be…
23d61ff 
…nchmarks (pandas-dev#23265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Benchmark Performance (ASV) benchmarks Clean
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

Remove unused asv directives and verify in the CI that we are not using them
4 participants
@eriknil @pep8speaks @jreback @WillAyd