MFTF 2.3.13 - Merge Develop to Master #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted actions - Added WAIT_TIMEOUT environment variable to .env file - Implemented getDefaultWaitTimeout method that retrieves WAIT_TIMEOUT environment variable or a constant value - Edited wait action methods to use default timeout if not set
…ted actions - Added Unit test for getDefaultWaitTimeout method
…ted actions - Added WAIT_TIMEOUT environment variable to .env file
…ted actions - Removed .env and updated .env.example file
…ted actions
- Transformed 'getDefaultWaitTimeout' into static method
…ted actions
- Used .env.example configuration file instead of .env
- Changed hardcoded value to environment variable
…ted actions - Added PHPDoc block to getDefaultWaitTimeout method - Changed usage of getDefaultWaitTimeout static method in other methods
…ted actions - Reverted MagentoWebDriver class - Moved getDefaultWaitTimeout method to ActionObject class - Changed generateStepsPhp method in TestGenerator class to use timeout from getDefaultWaitTimeout method if not set - Moved and fixed unit test for the implementation
#54: Set a global value for timeouts that's used across all wait related actions
(cherry picked from commit f463ebd)
(cherry picked from commit 14d65c2)
… when making a request
(cherry picked from commit 73c4371)
(cherry picked from commit 231fe18)
… with 503 - Disabled MagentoRestDriver
…tadata - Fixed static test failures
…alling HTTP endpoints
…TestingFramework\Util\Protocol\CurlTransport)
- Adding a new action for waitForReactPageLoad to the schema. - Adding basic structure for the new action to the MagentoWebDriver.
# Conflicts: # src/Magento/FunctionalTestingFramework/DataGenerator/Persist/Curl/WebapiExecutor.php
MQE-1353 & 1354
- Switched gears with this attempt, created a waitForElementVisible action instead of a waitForReactPageLoad action. - Adding new action, DI updates and Actions updates.
- Renaming the new Actions to make it clear what they are for. Replaced "Js" with "Pwa".
- Updating the action name in the Generator file.
- Created a separate Class for the custom PWA actions. - Removed the custom PWA actions from MagentoWebDriver.
MQE-1382: New PWA "waitFor" Actions
Master to develop 2.3.12
…update composer.json - Added Conditional for checking Codeception Version
Allow = to be part of the secret value
MQE-1145: Update FrontendExecutor::authorize() method.
- added \ to codeception usage.
- Added 2.3.13 changelog and bumped version in composer/lock file
…orrectly" This reverts commit 2fe867c.
- Removing fix line from ChangeLog
Revert MQE-1185
|
|
|
@vasylmalanka could you sign the CLA so that we can include your contributions in the upcoming MFTF release? |
KevinBKozan
changed the title
okolesnyk
approved these changes
Jan 29, 2019
| - \Magento\FunctionalTestingFramework\Module\MagentoSequence | ||
| - \Magento\FunctionalTestingFramework\Module\MagentoAssert | ||
| - Asserts | ||
| config: | ||
| \Magento\FunctionalTestingFramework\Module\MagentoWebDriver: | ||
| url: "%MAGENTO_BASE_URL%" | ||
| backend_url: "%MAGENTO_BACKEND_BASE_URL%" |
There was a problem hiding this comment.
I think this changes should be reflected in Jenkins infra repo
https://github.com/magento-cicd/jenkins-infra/blob/master/mftf/mdc/functional.suite.yml.chrome
There was a problem hiding this comment.
Very good call. Builds are running fine without it, but I'll create a PR to update the above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution checklist