Skip to content

Set a global value for timeouts that's used across all wait related actions #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
okolesnyk opened this issue Mar 22, 2018 · 2 comments

Comments

@okolesnyk
Copy link
Member

Description

Currently, each wait related action has their own specified default timeout stored on vendor/codeception/codeception/src/Codeception/Module/WebDriver.php. These values are different for each action. It would be better to have 1 global value that all of these actions read from and use as the default. Test writers could overwrite this default in their xml test steps

Acceptance Criteria

  1. All wait related actions read their default timeout value from a single, global variable
  2. All wait related actions can have the default value overridden by providing timeout attribute on the action level (from a test step or action group step)
  3. Global value is set to 10 seconds by default
@okolesnyk
Copy link
Member Author

Communicated with @vasylmalanka regarding this issue via Slack. He is trying to use native Codeception Wait class to define global value for all waits. In case of any problems Vasyl can ask any questions in Slack or left any comments here.

okolesnyk added a commit that referenced this issue Aug 29, 2018
#54: Set a global value for timeouts that's used across all wait related actions
@okolesnyk
Copy link
Member Author

Pull Request merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants