magento/magento2-functional-testing-framework#54: Set a global value for timeouts that's used across all wait related actions #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted actions - Added WAIT_TIMEOUT environment variable to .env file - Implemented getDefaultWaitTimeout method that retrieves WAIT_TIMEOUT environment variable or a constant value - Edited wait action methods to use default timeout if not set
…ted actions - Added Unit test for getDefaultWaitTimeout method
…ted actions - Added WAIT_TIMEOUT environment variable to .env file
…ted actions - Removed .env and updated .env.example file
…ted actions
- Transformed 'getDefaultWaitTimeout' into static method
…ted actions
- Used .env.example configuration file instead of .env
- Changed hardcoded value to environment variable
…ted actions - Added PHPDoc block to getDefaultWaitTimeout method - Changed usage of getDefaultWaitTimeout static method in other methods
|
Communicated with @vasylmalanka regarding this issue via Slack. He is trying to use native Codeception Wait class to define global value for all waits. In case of any problems Vasyl can ask any questions in Slack or left any comments here. |
…ted actions - Reverted MagentoWebDriver class - Moved getDefaultWaitTimeout method to ActionObject class - Changed generateStepsPhp method in TestGenerator class to use timeout from getDefaultWaitTimeout method if not set - Moved and fixed unit test for the implementation
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jul 23, 2021
3.6.0 Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edited wait action methods to use wait timeout value from .env file.
Fixed Issues (if relevant)
Contribution checklist