Skip to content

Revert MQE-1185 #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2019
Merged

Revert MQE-1185 #305

merged 2 commits into from
Jan 28, 2019

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Bug fix in MQE-1185 found to create backwards incompatibility
  • Reverting fix and changelog for inclusion in MFTF 3.0.0

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan KevinBKozan requested a review from jilu1 January 28, 2019 15:41
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.054% when pulling 2953a24 on MQE-1185-Revert into e5a736a on develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.054% when pulling 2953a24 on MQE-1185-Revert into e5a736a on develop.

jilu1
jilu1 approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@KevinBKozan KevinBKozan merged commit 9b7d464 into develop Jan 28, 2019
@KevinBKozan KevinBKozan deleted the MQE-1185-Revert branch January 28, 2019 16:19
magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 15, 2023
@jilu1
Merge pull request #305 from magento-gl/master
0cd8a72 
Merging master back to develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @jilu1