Lower Apple Platform requirement in Package.swift #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Ye
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
ejvaughan,
grynspan,
stmontgomery and
suzannaratcliff
as code owners
Contributor
|
@swift-ci please test |
Contributor
|
Per my recent reply, I think we can proceed with this. But first: I'm running CI again to confirm a theory that this will fail on macOS because I landed a change in #104 that requires newer OS versions after this PR was posted. I have a fix incoming for that, however, so we can land that first and then proceed with landing this. |
Contributor
|
@swift-ci please test |
stmontgomery
approved these changes
Nov 16, 2023
Contributor
stmontgomery
left a comment
stmontgomery
left a comment
There was a problem hiding this comment.
Approving, but waiting to merge until CI failures are resolved
Contributor
|
CI is failing in the way I would expect, now. Fixing that in #121 |
Contributor
|
@swift-ci please test |
grynspan
added a commit
that referenced
this pull request
Nov 17, 2023
#102 introduced a warning when building the GitStatus executable, which we use to get repo information during building: > [!WARNING] > ``` > swift-testing/Sources/GitStatus/main.swift:65:24: warning: no calls to throwing functions occur within 'try' expression > guard let output = try? stdoutPipe.fileHandleForReading.readData(ofLength: maxOutputCount) else { > ^ > ``` This PR resolves the warning.
2 tasks
grynspan
added a commit
that referenced
this pull request
Nov 17, 2023
#102 introduced a warning when building the GitStatus executable, which we use to get repo information during building: > [!WARNING] > ``` > swift-testing/Sources/GitStatus/main.swift:65:24: warning: no calls to throwing functions occur within 'try' expression > guard let output = try? stdoutPipe.fileHandleForReading.readData(ofLength: maxOutputCount) else { > ^ > ``` This PR resolves the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower Apple Platform requirement in Package.swift
Motivation:
Close #101
Modifications:
Lower Apple Platform requirement in Package.swift
Result:
A Package with iOS 13 support can at least have a dependency on it.
Checklist: