Lower the 'TestCases' protocol to internal #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
ejvaughan,
grynspan and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci please test |
grynspan
reviewed
Nov 9, 2023
Contributor
Author
|
@swift-ci please test |
grynspan
approved these changes
Nov 9, 2023
This was referenced Nov 16, 2023
stmontgomery
added a commit
that referenced
this pull request
Nov 16, 2023
…wer OS versions This fixes a build failure seen when attempting to build for macOS/iOS versions older than 13.0/16.0, respectively, which was introduced in #104. This introduces a type-erasing wrapper, which fixes the failure and also improves the `Test.testCases` derived property by allowing it to use `some` instead of `any` and further constraining the return type to `Sendable`.
2 tasks
stmontgomery
added a commit
that referenced
this pull request
Nov 16, 2023
…wer OS versions (#121) This fixes a build failure seen when attempting to build for macOS/iOS versions older than 13.0/16.0, respectively, which was introduced in #104. This introduces a type-erasing wrapper, which fixes the failure and also improves the `Test.testCases` derived property by allowing it to use `some` instead of `any` and further constraining the return type to `Sendable`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower the access level of the
TestCasesprotocol from@_spi publictointernal(implicitly).Motivation:
Due to some limitations in Swift's type system, we currently need a protocol named
TestCasesas a workaround to type-erase our sequence of test cases so that it can be constrained toSendable(see comment). But because theTest.testCasesispublic, that protocol also needs to match its access level. Since this protocol is just a workaround, we'd rather not expose the protocol and only expose a property returning aSequenceof test case instances onTest.Modifications:
Test._testCasesas aprivatestored property of type(any TestCases)?.Test.testCasesto a computed property which conditionally down-castsself._testCases.TestCasesprotocol tointernal.Result:
The
TestCasesprotocol is no longer exposed, and the type of the computedTest.testCasesproperty isany Sequence<Test.Case>.Checklist: