Skip to content

Fix a build warning in the git status plugin. #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix a build warning in the git status plugin. #123

merged 1 commit into from
Nov 17, 2023

Conversation

@grynspan
Copy link
Contributor

@grynspan grynspan commented Nov 17, 2023 •
edited
Loading

#102 introduced a warning when building the GitStatus executable, which we use to get repo information during building:

Warning

swift-testing/Sources/GitStatus/main.swift:65:24: warning: no calls to throwing functions occur within 'try' expression
    guard let output = try? stdoutPipe.fileHandleForReading.readData(ofLength: maxOutputCount) else {
                       ^

This PR resolves the warning.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Fix a build warning in the git status plugin.
803bf95 
 #102 introduced a warning when building the GitStatus executable, which we use to get repo information during building:

> [!WARNING]
> ```
> swift-testing/Sources/GitStatus/main.swift:65:24: warning: no calls to throwing functions occur within 'try' expression
>     guard let output = try? stdoutPipe.fileHandleForReading.readData(ofLength: maxOutputCount) else {
>                        ^
> ```

This PR resolves the warning.
@grynspan
Copy link
Contributor Author

grynspan commented Nov 17, 2023

@swift-ci please test

@grynspan grynspan merged commit e9e6124 into main Nov 17, 2023
@grynspan grynspan deleted the jgrynspan/fix-gitstatus-regression branch November 17, 2023 18:57
@stmontgomery stmontgomery added the bug 🪲 Something isn't working label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisweissmann dennisweissmann dennisweissmann approved these changes

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff

@ejvaughan ejvaughan Awaiting requested review from ejvaughan

Assignees

@grynspan grynspan

Labels

bug 🪲 Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grynspan @dennisweissmann @stmontgomery