Skip to content

Refactor and update existing base BLAS packages according to current project conventions #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
18 tasks done
kgryte opened this issue Dec 31, 2022 · 6 comments
Closed
18 tasks done

Refactor and update existing base BLAS packages according to current project conventions #788

kgryte opened this issue Dec 31, 2022 · 6 comments
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons. Tracking Issue Tracking issue.

Comments

@kgryte
Copy link
Member

kgryte commented Dec 31, 2022 •
edited
Loading

BLAS Updates

Refactor and clean-up existing base BLAS packages according to current project conventions.

Existing base BLAS packages need to be updated according to current project conventions before we can continue building out additional BLAS functionality. What follows is a general list of necessary changes, along with a list of packages which should be updated.

An example commit implementing (most of) these changes can be found in d66d80c (saxpy).

Updates

  1. replace nullptr with NULL
  2. remove namespace (and anything else C++) and use static functions
  3. rename file from addon.cpp to addon.c
  4. update include.gypi to reference addon.c file
  5. use argv macros for handling add-on callback arguments
  6. update benchmarks to use utility functions for generating arrays of random numbers, rather than explicit loops
  7. change "destination array" and "returns y" to "output array" and "returns output array" respectively
  8. change "deep equal" to "returns expected value"
  9. remove use of floor
  10. README and repl.txt copy edits
  11. in *.native.js files, use utilities for creating offset views, rather than explicit typed array creation
  12. update manifest.json file to include argv utility dependencies
  13. update manifest.json to use space indentation to match other project JSON files
  14. update manifest.json to include separate build configurations for compiling the addon, the benchmarks, and the examples.

Packages
@kgryte kgryte added Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Dec 31, 2022
@Pranavchiku
Copy link
Member

Working on blas/base/sswap.

@Pranavchiku
Copy link
Member

On blas/base/scopy.

@Pranavchiku
Copy link
Member

Refactoring blas/base/sdot.

@Pranavchiku
Copy link
Member

Refactoring blas/base/sdsdot.

@Pranavchiku
Copy link
Member

Refactoring blas/base/snrm2.

kgryte added a commit that referenced this issue Mar 1, 2023
@Pranavchiku @kgryte
refactor: update add-on, examples, benchmarks, and docs
663577c 
This commit is part of the work discussed in #788 and updates `@stdlib/blas/base/sdot` according to current project conventions, particularly as concerns the native add-on bridge between JavaScript and C.

PR-URL: #798
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Mar 1, 2023
@Pranavchiku @kgryte
refactor: update add-on, benchmarks, tests, and examples
710ea41 
This commit migrates `@stdlib/blas/base/snrm2` to use current project conventions for authoring add-ons, as discussed in #788.

PR-URL: #800
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Mar 2, 2023
@Pranavchiku @kgryte
refactor: update add-on, examples, benchmarks, and docs
c8985f2 
This commit migrates `@stdlib/blas/base/sdsdot` to use current project conventions, as discussed in #788.

PR-URL: #799
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Dec 1, 2023
@kgryte
refactor: update implementation in accordance with current project co…
3c82fe7 
…nventions

Ref: #788
kgryte added a commit that referenced this issue Dec 1, 2023
@kgryte
refactor: update implementation in accordance with current project co…
5b15c96 
…nventions

Ref: #788
kgryte added a commit that referenced this issue Dec 1, 2023
@kgryte
refactor: update implementation according to current project conventions
2705ac1 
Ref: #788
kgryte added a commit that referenced this issue Dec 1, 2023
@kgryte
refactor: update implementation according to current project conventions
2b57f34 
Ref: #788
kgryte added a commit that referenced this issue Dec 2, 2023
@kgryte
refactor: update implementation according to current project conventions
ca64b6b 
Ref: #788
kgryte added a commit that referenced this issue Dec 2, 2023
@kgryte
refactor: update tests and benchmarks according to current project co…
067e5d4 
…nventions

Ref: #788
kgryte added a commit that referenced this issue Dec 2, 2023
@kgryte
refactor: update tests and benchmarks according to current project co…
83ecb8e 
…nventions

Ref: #788
kgryte added a commit that referenced this issue Dec 3, 2023
@kgryte
refactor: update implementation according to current project conventions
3272b77 
Ref: #788
kgryte added a commit that referenced this issue Dec 4, 2023
@kgryte
refactor: update implementation according to current project conventions
91a2bad 
Ref: #788
kgryte added a commit that referenced this issue Dec 4, 2023
@kgryte
refactor: update implementation according to current project conventions
c1bd97d 
Ref: #788
kgryte added a commit that referenced this issue Dec 4, 2023
@kgryte
refactor: update implementation according to current project conventions
11a8792 
Ref: #788
kgryte added a commit that referenced this issue Dec 4, 2023
@kgryte
refactor: update implementation according to current project conventions
a86fb6b 
Ref: #788
kgryte added a commit that referenced this issue Dec 4, 2023
@kgryte
refactor: update implementation according to current project conventions
6103e65 
Ref: #788
kgryte added a commit that referenced this issue Dec 4, 2023
@kgryte
refactor: update implementation according to current project conventions
3818752 
Ref: #788
kgryte added a commit that referenced this issue Dec 4, 2023
@kgryte
refactor: update implementation according to current project conventions
2fa27d7 
Ref: #788
@kgryte kgryte mentioned this issue Dec 4, 2023
Closed
82 tasks
@kgryte
Copy link
Member Author

kgryte commented Dec 4, 2023

This work has now been completed. Closing...

@kgryte kgryte closed this as completed Dec 4, 2023
@kgryte kgryte mentioned this issue Mar 1, 2024
Closed
3 tasks
@Planeshifter Planeshifter mentioned this issue Mar 3, 2024
Closed
3 tasks
This was referenced Mar 3, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@lovelindhoni lovelindhoni mentioned this issue Mar 3, 2024
Merged
1 task
kgryte added a commit that referenced this issue Mar 4, 2024
@lovelindhoni @kgryte
refactor: update blas/ext/base/ssumpw to follow current project con…
412acd6 
…ventions

Closes: #1544
PR-URL: 	#1673
Ref: #788
Ref: #1152
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Lovelin <100030865+lovelindhoni@users.noreply.github.com>
@kgryte kgryte added the Tracking Issue Tracking issue. label Mar 4, 2024
@lovelindhoni lovelindhoni mentioned this issue Mar 4, 2024
Merged
1 task
@PraneGIT PraneGIT mentioned this issue Mar 6, 2024
Merged
1 task
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this issue Mar 7, 2024
@lovelindhoni @kgryte
refactor: update blas/ext/base/ssumpw to follow current project con…
1267ce6 
…ventions

Closes: stdlib-js#1544
PR-URL: 	stdlib-js#1673
Ref: stdlib-js#788
Ref: stdlib-js#1152
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Lovelin <100030865+lovelindhoni@users.noreply.github.com>
@nightknighto nightknighto mentioned this issue Mar 8, 2024
Merged
1 task
@rxbryan rxbryan mentioned this issue Mar 11, 2024
Merged
1 task
@kumarsuraj212003 kumarsuraj212003 mentioned this issue Mar 15, 2024
Merged
1 task
@Jai0401 Jai0401 mentioned this issue Mar 16, 2024
Merged
1 task
This was referenced Mar 17, 2024
Merged
Merged
Merged
This was referenced Mar 21, 2024
Merged
Merged
Closed
Merged
@AuenKr AuenKr mentioned this issue Mar 26, 2024
Closed
6 tasks
@Jai0401 Jai0401 mentioned this issue Mar 26, 2024
Merged
1 task
@Jai0401 Jai0401 mentioned this issue Jun 4, 2024
Merged
1 task
This was referenced Sep 2, 2024
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons. Tracking Issue Tracking issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgryte @Pranavchiku