Skip to content

refactor: update add-on, examples, benchmarks, and docs #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 1, 2023
Merged

refactor: update add-on, examples, benchmarks, and docs #798

merged 13 commits into from
Mar 1, 2023

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Jan 22, 2023 •
edited
Loading

Checklist

  • update readme.md
  • docs
  • src
  • include.gypi
  • manifest.json
  • package.json
  • lib
  • examples
  • benchmark
  • test ( No noticable change )

@kgryte

@Pranavchiku Pranavchiku mentioned this pull request Jan 22, 2023
Closed
18 tasks
@Pranavchiku Pranavchiku added Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Jan 22, 2023
@Pranavchiku
Copy link
Member Author

All tests and benchmarks cleared. This PR can have a review.

@Pranavchiku Pranavchiku marked this pull request as ready for review January 22, 2023 05:20
kgryte
kgryte requested changes Jan 31, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the returns descriptions.

@kgryte
Copy link
Member

kgryte commented Feb 14, 2023

@Pranavchiku LMK once the return value descriptions are updated, and I'll take another look.

@Pranavchiku
Copy link
Member Author

@kgryte updated description, kindly have a look.

@kgryte
Copy link
Member

kgryte commented Feb 23, 2023

@Pranavchiku Similar to another PR, instead of force pushing, better to pull, merge, and resolve local conflicts, rather than overwriting public history. Some of the line wrapping in repl.txt may need to be restored.

@Pranavchiku
Copy link
Member Author

@kgryte you can have a final review.

kgryte
kgryte approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Pranavchiku!

@kgryte kgryte changed the title Refactor @stdlib/blas/base/sdot refactor: update add-on, examples, benchmarks, and docs Mar 1, 2023
@kgryte kgryte merged commit 663577c into stdlib-js:develop Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @kgryte