-
-
Notifications
You must be signed in to change notification settings - Fork 818
refactor: update add-on, benchmarks, tests, and examples #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some tests are failing, below is given log # the function supports a negative `stride` parameter
not ok 9 returns expected value
---
operator: equal
expected: 5
actual: 0
at: Test.test (/home/pranavchiku/stdlib/lib/node_modules/@stdlib/blas/base/snrm2/test/test.ndarray.native.js:124:4)
... I am not sure why it is happening, @kgryte if you can have a look. |
@Pranavchiku The test failures are due to your having removed the logic for ensuring that the |
Okay, I will have a look asap. |
@Pranavchiku LMK once this PR has been updated, and I'll take another look. |
@kgryte updated this PR, you can have a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Pranavchiku!
@Pranavchiku This PR is currently marked as a draft. I assume that this is ready for merge? |
Yes, I forgot to make it ready to review. |
@stdlib/blase/base/snrm2
Checklist
@kgryte