Skip to content

DATAMONGO-1322 - Add support for validator when creating collection. #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DATAMONGO-1322 - Add support for validator when creating collection. #511

wants to merge 1 commit into from

Conversation

a-zink
Copy link

@a-zink a-zink commented Oct 28, 2017

Extended the CollectionOptions with a ValidationOptions property which
corresponds to the MongoDB createCollection() parameters. A validator
object can be defined using the Criteria API, or by writing a custom
provider.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@a-zink
DATAMONGO-1322 - Add support for validator when creating collection.
d9779a1 
Extended the CollectionOptions with a ValidationOptions property which
corresponds to the MongoDB createCollection() parameters. A validator
object can be defined using the Criteria API, or by writing a custom
provider.
@christophstrobl
Copy link
Member

thank you very much @a-zink we'll take it from here.

This was referenced Jan 10, 2018
Closed
Closed
mp911de pushed a commit that referenced this pull request Jan 16, 2018
@a-zink @mp911de
DATAMONGO-1322 - Add support for Criteria-based validator for collect…
2024b30 
…ion creation.

Extended the CollectionOptions with a ValidationOptions property which
corresponds to the MongoDB createCollection() parameters. A validator
object can be defined using the Criteria API, or by writing a custom
provider.

Original pull request: #511.
Related pull request: #525.
Related ticket: DATACMNS-1835.
mp911de pushed a commit that referenced this pull request Jan 16, 2018
@christophstrobl @mp911de
DATAMONGO-1322 - Polishing.
36614ef 
Remove ValidationAction/Level and ValidationOptions duplicates. Rename ValidatorDefinition to Validator and Validator to ValidationOptions.
Update and rename some of the tests. Also make sure to run the created validator document through the QueryMapper for value conversion and potential field mappings. Streamline Validator usage by providing plain Document and JsonSchema validator options next to the Criteria based one.
Finally update the reference documentation.

Original pull request: #525.
Related pull request: #511.
Related ticket: DATACMNS-1835.
mp911de added a commit that referenced this pull request Jan 16, 2018
@mp911de
DATAMONGO-1322 - Polishing.
c3dbce4 
Convert lineendings from CRLF to LF. Reduce validator implementations visibility to package. Extend Javadoc. Slight rewording in reference documentation.

Original pull request: #525.
Related pull request: #511.
Related ticket: DATACMNS-1835.
@mp911de
Copy link
Member

mp911de commented Jan 16, 2018

That's merged and polished now.

@mp911de mp911de closed this Jan 16, 2018
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-zink @christophstrobl @mp911de