Add support for validator when creating collection. [DATAMONGO-1322]

[spring-projects-issues]

Christoph Strobl opened DATAMONGO-1322 and commented

db.createCollection( "contacts", {
   validator: { $or:
      [
         { phone: { $type: "string" } },
         { email: { $regex: /@mongodb\.com$/ } },
         { status: { $in: [ "Unknown", "Incomplete" ] } }
      ]
   }
} )

NOTE: investigate usage if JSR-303 for defining validation to be propagated to the collection

---

Reference URL: https://docs.mongodb.org/master/release-notes/3.2/#validator

Issue Links:

• DATAMONGO-1835 Add support for $jsonSchema to Criteria API

• DATAMONGO-1849 Generate $jsonSchema out of domain type meta information

Referenced from: pull request #525, and commits 0ce34d8, c3dbce4, 36614ef, 2024b30, b00054f, 5947980

1 votes, 3 watchers

[spring-projects-issues]

Andreas Zink commented

Implemented a simple extension for MongoTemplate and CollectionOptions to setup validation rules. Created pull request #511

[spring-projects-issues]

Andreas Zink commented

Evaluated the use of JSR-303 annotations to build a MongoDB validator object. In my opinion those validation rules can't be applied properly to MongoDB document validation.

First of all, some annotations can't be applied at all. For example javax.validation.constraints.Future, javax.validation.constraints.Past or javax.validation.constraints.Size simply can't be applied as MongoDB query.

Second, also the easy validation rules can be become very complex in certain models. Image a simple Bean which holds a list of other Beans.

public class CompositeBean{
	@NotNull @Valid private List<Bean> list;
}

public class Bean{
	@Min(0) private Integer value;
}

The problem is, that a validator could only match if at least one list element is valid. For example

{	
	"list.value":{ $gte: 0 }
}

would allow document insertions of lists containing invalid elements if there is at least one valid element. This is just how MongoDB works here (see $eq). Really matching all list elements would became very complex (e.g. see here http://www.askasya.com/post/matchallarrayelements/) as it would require to negate the meaning of the validation annotations etc.

So my conclusion is, that if using JSR-303 annotations, a feature as introduced with DATAMONGO-36 is more useful as it really can provide all the validation features. Still, my implementation allows to be extended easily and maybe the use of JSR-303 for MongoDB validation can be evaluated in detail within a new ticket.

[spring-projects-issues]

Christoph Strobl commented

Original Pull Request: #511