DATAMONGO-1322 - Add support for validator when creating collection. #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the CollectionOptions with a ValidationOptions property which corresponds to the MongoDB createCollection() parameters. A validator object can be defined using the Criteria API, or by writing a custom provider.
Remove ValidationAction/Level and ValidationOptions duplicates. Rename ValidatorDefinition to Validator and Validator to ValidationOptions. Update and rename some of the tests. Also make sure to run the created validator document through the QueryMapper for value conversion and potential field mappings. Streamline Validator usage by providing plain Document and JsonSchema validator options next to the Criteria based one. Finally update the reference documentation.
mp911de
pushed a commit
that referenced
this pull request
Jan 16, 2018
…ion creation. Extended the CollectionOptions with a ValidationOptions property which corresponds to the MongoDB createCollection() parameters. A validator object can be defined using the Criteria API, or by writing a custom provider. Original pull request: #511. Related pull request: #525. Related ticket: DATACMNS-1835.
mp911de
pushed a commit
that referenced
this pull request
Jan 16, 2018
Remove ValidationAction/Level and ValidationOptions duplicates. Rename ValidatorDefinition to Validator and Validator to ValidationOptions. Update and rename some of the tests. Also make sure to run the created validator document through the QueryMapper for value conversion and potential field mappings. Streamline Validator usage by providing plain Document and JsonSchema validator options next to the Criteria based one. Finally update the reference documentation. Original pull request: #525. Related pull request: #511. Related ticket: DATACMNS-1835.
mp911de
added a commit
that referenced
this pull request
Jan 16, 2018
Convert lineendings from CRLF to LF. Reduce validator implementations visibility to package. Extend Javadoc. Slight rewording in reference documentation. Original pull request: #525. Related pull request: #511. Related ticket: DATACMNS-1835.
Member
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a
ValidatorusingCriteriato build query expression based collection validation.incorporates and supersedes: #511