Fixed the ability to search for a user by ID #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 62.59% (diff: 100%)@@ master #152 diff @@
==========================================
Files 8 8
Lines 257 262 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 159 164 +5
Misses 98 98
Partials 0 0
|
|
@Roach or @DEGoodmanWilson I see you released this as 1.0.4 -- thanks for getting that out so quickly! Just wanted to point out in case it was an oversight that you didn't push the |
Contributor
Author
|
@TheKevJames d'oh! fixed that, too: #153 |
5 tasks
c-goosen
pushed a commit
to c-goosen/python-slackclient
that referenced
this pull request
Jun 18, 2019
* Fixed the ability to search for a user by ID * Added test for invalid user search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Related Issues
Test strategy
✅ I've read and understood the Contributing guidelines
✅ I've read and agree to the Code of Conduct
✅ I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
✅ I've a descriptive title and added any useful information for the reviewer.
✅ I've written tests to cover the new code and functionality included in this PR.
✅ I've read, agree to, and signed the Contributor License Agreement