Skip to content

Breaking change to user search in latest patch release. #151

@b-i-l-l

Description

@b-i-l-l
  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Description

The users attribute of the server object was changed from SearchList to SearchDict. This is a breaking change that was not reflected in the version number. Furthermore this dictionary is keyed by name while the SearchList used the user object's __eq__ method to search by id or name. A basic function is now broken, namely resolving a user identity from the Slack id contained in most events.

e.g. Description of the bug or feature

Reproducible in:

  • This is reproducible in the sample project.
    python-slackclient version:
    Python Version:
    OS Version:

Steps to reproduce:

Expected result:

e.g. What you expected to happen

Actual result:

e.g. What actually happened

Attachments:

e.g. Logs, screenshots, screencast, sample project, funny gif, etc.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions