Skip to content

Conversation

@Roach
Copy link
Contributor

@Roach Roach commented Dec 16, 2016

PR Summary

Bumped version to 1.0.4 for pypi release

  • ✅ I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • ✅ I've read and agree to the Code of Conduct.
  • ✅ I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • ✅ I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).
  • ✅ I've written tests to cover the new code and functionality included in this PR.
  • ✅ I've read, agree to, and signed the Contributor License Agreement (CLA).

@codecov-io
Copy link

codecov-io commented Dec 16, 2016

Current coverage is 62.59% (diff: 100%)

Merging #153 into master will not change coverage

@@             master       #153   diff @@
==========================================
  Files             8          8          
  Lines           262        262          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            164        164          
  Misses           98         98          
  Partials          0          0          

Powered by Codecov. Last update d181101...e6c6e95

Copy link

@UncannyBingo UncannyBingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH NO!

@UncannyBingo UncannyBingo merged commit f89ac71 into master Dec 16, 2016
@UncannyBingo UncannyBingo deleted the roach/1.0.4 branch December 16, 2016 00:19
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants