Try to enable manual screen tracking #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segmentio/analytics-ios-integrations#11 is the matching iOS pull request, which has been tested and is confirmed to work |
stianjensen
force-pushed
the
screen-tracking
branch
from
5171081 to
b8b1088
Compare
Contributor
Author
|
Added a unit test for the screen tracking now. |
Contributor
|
@stianjensen I am closing this PR out as we deployed this change in this PR today: #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segment’s documentation mentions that screen events are not passed through to the Firebase SDK because Firebase does automatic screen tracking. (https://segment.com/docs/connections/destinations/catalog/firebase/#screen)
However, it mentions that Automatic+Manual screen tracking should be supported, but this currently does not work because Segment does not forward the manual screen tracking events.
Like on iOS, this attempts to let explicitly tracked screens in analytics-react-native using analytics.screen actually be tracked in Firebase.
I haven't been able to test this code locally, since I'm not very familiar with Gradle, and how to get a locally edited version of this to run in my project, but I'm opening this in any case as an example of a matching implementation of an iOS fix - and hoping someone knows how to test this, or can think of an alternative implementation ✌️