[STRATCONN-39] Enable manual screen tracking #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brennan
reviewed
Feb 20, 2020
| public void onActivityStopped(Activity activity) { | ||
| super.onActivityStopped(activity); | ||
|
|
||
| this.currentActivity = null; |
Contributor
There was a problem hiding this comment.
I think this here will refer to onActivityStopped rather than FirebaseIntegration, which I think is what you actually want.
Contributor
Author
There was a problem hiding this comment.
@brennan I added integration.onActivityStopped(activity); after the integration.onActivityStarted(activity) in the unit tests locally to inspect the values. Looks like this is referring to FirebaseIntegration:
brennan
reviewed
Feb 20, 2020
src/main/java/com/segment/analytics/android/integrations/firebase/FirebaseIntegration.java
Outdated
Show resolved
Hide resolved
brennan
reviewed
Feb 20, 2020
src/test/java/com/segment/analytics/android/integration/firebase/FirebaseTest.java
Outdated
Show resolved
Hide resolved
brennan
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Changes were migrated from PR #26 to update SNAPSHOT and prep for release.
Changes:
Segment’s documentation mentions that screen events are not passed through to the Firebase SDK because Firebase does automatic screen tracking. (https://segment.com/docs/connections/destinations/catalog/firebase/#screen)
However, it mentions that Automatic+Manual screen tracking should be supported, but this currently does not work because Segment does not forward the manual screen tracking events.
Like on iOS, this attempts to let explicitly tracked screens in analytics-react-native using analytics.screen actually be tracked in Firebase.
I haven't been able to test this code locally, since I'm not very familiar with Gradle, and how to get a locally edited version of this to run in my project, but I'm opening this in any case as an example of a matching implementation of an iOS fix - and hoping someone knows how to test this, or can think of an alternative implementation ✌️