This repository was archived by the owner on Jun 14, 2023. It is now read-only.
Track screens explicitly in Firebase #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosMecha
suggested changes
Jan 28, 2020
Contributor
CarlosMecha
left a comment
CarlosMecha
left a comment
There was a problem hiding this comment.
Hi! Thank you so much for submitting the chnage. Would be possible to add unitests too?
Contributor
Author
|
I added a test now! Is that good, or is there something more specific I should test for? As far as I can see, Firebase doesn't take any extra properties or anything for its screen tracking method, so I don't think adding any specific properties, contexts would do anything at least. |
briemcnally
approved these changes
Feb 14, 2020
briemcnally
added a commit
that referenced
this pull request
Feb 14, 2020
This reverts commit 316399d.
briemcnally
added a commit
that referenced
this pull request
Feb 14, 2020
Contributor
|
hey @stianjensen I am releasing this on our legacy Firebase repo: segment-integrations/analytics-ios-integration-firebase#48. This iOS monorepo is still a work in progress and not yet adequately ready for contributions/releases. I will be releasing version 2.6.0 momentarily. Thanks for your contribution :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segment’s documentation mentions that screen events are not passed through to the Firebase SDK because Firebase does automatic screen tracking. (https://segment.com/docs/connections/destinations/catalog/firebase/#screen)
However, it mentions that Automatic+Manual screen tracking should be supported, but this currently does not work because Segment does not forward the manual screen tracking events.
This change will allow explicitly tracked screens in analytics-react-native using
analytics.screento actually be tracked in Firebase.