Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore doctests only in specified targets #138877

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore doctests only in specified targets #138877

wants to merge 1 commit into from
+25 −4

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Mar 24, 2025 •
edited
Loading

Quick fix for #138863

FIxes #138863

cc @yotamofek @notriddle

@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Mar 24, 2025
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Mar 24, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2025
@bors
Auto merge of rust-lang#138877 - TaKO8Ki:enable-per-target-ignores-fo…
835ba57 
…r-doctests, r=<try>

Ignore doctests only in specified targets

Quick fix for rust-lang#138863

cc `@yotamofek` `@notriddle`
@bors
Copy link
Contributor

bors commented Mar 24, 2025

⌛ Trying commit 3dae3fb with merge 835ba57...

@TaKO8Ki TaKO8Ki mentioned this pull request Mar 24, 2025
Open
@bors
Copy link
Contributor

bors commented Mar 24, 2025

☀️ Try build successful - checks-actions
Build commit: 835ba57 (835ba573e2e0bda344ac6cbb78a8bb20aedda4bf)

weihanglo
weihanglo approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fix.
(I am not on t-rustdoc though)

@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 24, 2025

📌 Commit 3dae3fb has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2025
TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request Mar 24, 2025
@TaKO8Ki
Rollup merge of rust-lang#138877 - TaKO8Ki:enable-per-target-ignores-…
3ad01b7 
…for-doctests, r=notriddle

Ignore doctests only in specified targets

Quick fix for rust-lang#138863

FIxes  rust-lang#138863

cc `@yotamofek` `@notriddle`
@TaKO8Ki TaKO8Ki mentioned this pull request Mar 24, 2025
Closed
TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request Mar 24, 2025
@TaKO8Ki
Rollup merge of rust-lang#138877 - TaKO8Ki:enable-per-target-ignores-…
3c04362 
…for-doctests, r=notriddle

Ignore doctests only in specified targets

Quick fix for rust-lang#138863

FIxes  rust-lang#138863

cc ``@yotamofek`` ``@notriddle``
@TaKO8Ki TaKO8Ki mentioned this pull request Mar 24, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2025
@bors
Auto merge of rust-lang#138912 - TaKO8Ki:rollup-optkc3z, r=TaKO8Ki
9e0c777 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#138385 (Keyword tweaks)
 - rust-lang#138580 (resolve: Avoid some unstable iteration 2)
 - rust-lang#138652 (Reintroduce remote-test support in run-make tests)
 - rust-lang#138701 (Make default_codegen_backend serializable)
 - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs)
 - rust-lang#138829 (Slightly reword triagebot ping message for `relnotes-interest-group`)
 - rust-lang#138837 (resolve: Avoid remaining unstable iteration)
 - rust-lang#138838 (Fix/tweak some tests in new solver)
 - rust-lang#138877 (Ignore doctests only in specified targets)
 - rust-lang#138895 (Add a helper for building an owner id in ast lowering)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2025
@bors
Auto merge of rust-lang#138912 - TaKO8Ki:rollup-optkc3z, r=TaKO8Ki
eacae09 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#138385 (Keyword tweaks)
 - rust-lang#138580 (resolve: Avoid some unstable iteration 2)
 - rust-lang#138652 (Reintroduce remote-test support in run-make tests)
 - rust-lang#138701 (Make default_codegen_backend serializable)
 - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs)
 - rust-lang#138829 (Slightly reword triagebot ping message for `relnotes-interest-group`)
 - rust-lang#138837 (resolve: Avoid remaining unstable iteration)
 - rust-lang#138838 (Fix/tweak some tests in new solver)
 - rust-lang#138877 (Ignore doctests only in specified targets)
 - rust-lang#138895 (Add a helper for building an owner id in ast lowering)

r? `@ghost`
`@rustbot` modify labels: rollup
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Mar 25, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 25, 2025
@TaKO8Ki
ignore doctests only in specified targets
90c541d 
add necessary lines

fix ui test error
@TaKO8Ki TaKO8Ki force-pushed the enable-per-target-ignores-for-doctests branch from 3dae3fb to 90c541d Compare March 25, 2025 06:40
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Mar 25, 2025 •
edited
Loading

@notriddle I have fixed CI errors. Could you approve this again? I approved instead. Thanks.

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Mar 25, 2025

@bors r=notriddle

@bors
Copy link
Contributor

bors commented Mar 25, 2025

📌 Commit 90c541d has been approved by notriddle

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 25, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 25, 2025
ehuss added a commit to ehuss/cargo that referenced this pull request Mar 25, 2025
@ehuss
Temporarily ignore cargo_test_doctest_xcompile_ignores
f077af2 
This was broken due to a change in
rust-lang/rust#138535. There is an approved PR
in rust-lang/rust#138877 to fix it, but it may
take a day or two for it to make its way to nightly. This should be
reverted after it hits nightly.
@ehuss ehuss mentioned this pull request Mar 25, 2025
Merged
ehuss added a commit to ehuss/cargo that referenced this pull request Mar 25, 2025
@ehuss
Temporarily ignore cargo_test_doctest_xcompile_ignores
98a273f 
This was broken due to a change in
rust-lang/rust#138535. There is an approved PR
in rust-lang/rust#138877 to fix it, but it may
take a day or two for it to make its way to nightly. This should be
reverted after it hits nightly.
github-merge-queue bot pushed a commit to rust-lang/cargo that referenced this pull request Mar 25, 2025
@weihanglo
Temporarily ignore cargo_test_doctest_xcompile_ignores (#15348)
e3b5faa 
This was broken due to a change in
rust-lang/rust#138535. There is an approved PR
in rust-lang/rust#138877 to fix it, but it may
take a day or two for it to make its way to nightly. This should be
reverted after it hits nightly.
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 26, 2025
@jhpratt
Rollup merge of rust-lang#138877 - TaKO8Ki:enable-per-target-ignores-…
fc8fc05 
…for-doctests, r=notriddle

Ignore doctests only in specified targets

Quick fix for rust-lang#138863

FIxes  rust-lang#138863

cc `@yotamofek` `@notriddle`
@jhpratt jhpratt mentioned this pull request Mar 26, 2025
Open
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2025
@bors
Auto merge of rust-lang#138956 - jhpratt:rollup-6g7ppwd, r=jhpratt
6e8abb5 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#138128 (Stabilize `#![feature(precise_capturing_in_traits)]`)
 - rust-lang#138834 (Group test diffs by stage in post-merge analysis)
 - rust-lang#138867 (linker: Fix staticlib naming for UEFI)
 - rust-lang#138874 (Batch mark waiters as unblocked when resuming in the deadlock handler)
 - rust-lang#138875 (Trusty: Fix build for anonymous pipes and std::sys::process)
 - rust-lang#138877 (Ignore doctests only in specified targets)
 - rust-lang#138885 (Fix ui pattern_types test for big-endian platforms)
 - rust-lang#138905 (Add target maintainer information for powerpc64-unknown-linux-musl)
 - rust-lang#138911 (Allow defining opaques in statics and consts)
 - rust-lang#138917 (rustdoc: remove useless `Symbol::is_empty` checks.)
 - rust-lang#138945 (Override PartialOrd methods for bool)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustdoc ignore-* markdown attribute ignores everything
6 participants
@TaKO8Ki @rustbot @bors @notriddle @weihanglo @GuillaumeGomez