resolve: Avoid some unstable iteration 2

[petrochenkov]

Continuation of #138502.

[rustbot]

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[petrochenkov]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 0bf529e with merge 76b788c...

[bors]

☀️ Try build successful - checks-actions
Build commit: 76b788c (76b788c7823d67ac8c17a7746ecc834386f99d10)

[rust-timer]

Finished benchmarking commit (76b788c): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.2%, 1.3%]	14
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.2%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.2%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.0%, 2.9%]	4
Improvements ✅ (primary)	-2.2%	[-3.4%, -0.6%]	5
Improvements ✅ (secondary)	-2.8%	[-4.3%, -1.4%]	30
All ❌✅ (primary)	-2.2%	[-3.4%, -0.6%]	5

Cycles

Results (secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.741s -> 776.431s (0.09%)
Artifact size: 365.10 MiB -> 365.08 MiB (-0.01%)

[petrochenkov]

Probably fine, unused-warnings is a stress test for single_imports.

[Nadrieril]

👍

@bors r+

[bors]

📌 Commit 0bf529e has been approved by Nadrieril

It is now in the queue for this repository.

[bors]

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

[bors]

⌛ Testing commit 0bf529e with merge 0e34c65...

[petrochenkov]

@bors rollup=maybe in case it spuriously fails.
This is a performance change, but only for one specific benchmark - unused-warnings.

[petrochenkov]

@bors retry

[Kobzol]

Should be fixed now after the revert.

@bors treeclosed-

[petrochenkov]

@bors r=Nadrieril

[bors]

📌 Commit ba4190c has been approved by Nadrieril

It is now in the queue for this repository.