Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group test diffs by stage in post-merge analysis #138834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 22, 2025

I think that this is clearer than including the stage in the test name.

To test e.g. on this PR:

$ curl https://ci-artifacts.rust-lang.org/rustc-builds/282865097d138c7f0f7a7566db5b761312dd145c/metrics-aarch64-gnu.json > metrics.json
$ cargo run --manifest-path src/ci/citool/Cargo.toml postprocess-metrics metrics.json --job-name aarch64-gnu --parent d9e5539a39192028a7b15ae596a8685017faecee > out.md

r? @marcoieni

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 22, 2025
@jieyouxu
Copy link
Member

Against the rollup, the output looks like:

Output

Bootstrap steps

--stage 2 test
total............................................................ 5573.53s
.bootstrap::core::build_steps::test::Tidy........................   51.73s
..bootstrap::core::build_steps::compile::Assemble................    0.00s
..bootstrap::core::build_steps::tool::Tidy.......................   25.17s
...bootstrap::core::build_steps::tool::ToolBuild.................   25.17s
....bootstrap::core::builder::Libdir.............................    0.00s
.....bootstrap::core::build_steps::compile::Sysroot..............    0.00s
.bootstrap::core::build_steps::compile::Assemble................. 2135.30s
..bootstrap::core::builder::Libdir...............................    0.44s
...bootstrap::core::build_steps::compile::Sysroot................    0.44s
..bootstrap::core::build_steps::llvm::Llvm.......................  410.46s
..bootstrap::core::build_steps::compile::Assemble................  573.69s
...bootstrap::core::builder::Libdir..............................    0.00s
....bootstrap::core::build_steps::compile::Sysroot...............    0.00s
...bootstrap::core::build_steps::compile::Rustc..................  452.75s
....bootstrap::core::build_steps::compile::Std...................   49.88s
.....bootstrap::core::build_steps::compile::StartupObjects.......    0.00s
.....bootstrap::core::build_steps::compile::StdLink..............    0.00s
....bootstrap::core::build_steps::compile::RustcLink.............    0.00s
...bootstrap::core::build_steps::compile::CodegenBackend.........   50.33s
...bootstrap::core::build_steps::tool::LldWrapper................   14.84s
....bootstrap::core::build_steps::tool::ToolBuild................    0.39s
....bootstrap::core::build_steps::llvm::Lld......................   14.45s
...bootstrap::core::build_steps::tool::WasmComponentLd...........   47.25s
....bootstrap::core::build_steps::tool::ToolBuild................   47.25s
...bootstrap::core::build_steps::tool::LlvmBitcodeLinker.........    8.52s
....bootstrap::core::build_steps::tool::ToolBuild................    8.52s
..bootstrap::core::build_steps::compile::Rustc...................  931.20s
...bootstrap::core::build_steps::compile::Std....................   89.94s
....bootstrap::core::build_steps::compile::StartupObjects........    0.00s
....bootstrap::core::build_steps::llvm::Sanitizers...............   10.96s
....bootstrap::core::build_steps::compile::StdLink...............    0.00s
...bootstrap::core::build_steps::compile::RustcLink..............    0.00s
..bootstrap::core::build_steps::compile::CodegenBackend..........  107.53s
..bootstrap::core::build_steps::tool::LldWrapper.................    0.64s
...bootstrap::core::build_steps::tool::ToolBuild.................    0.64s
..bootstrap::core::build_steps::tool::WasmComponentLd............   92.06s
...bootstrap::core::build_steps::tool::ToolBuild.................   92.06s
..bootstrap::core::build_steps::tool::LlvmBitcodeLinker..........   19.19s
...bootstrap::core::build_steps::tool::ToolBuild.................   19.19s
.bootstrap::core::build_steps::test::Ui..........................  564.60s
..bootstrap::core::build_steps::test::Compiletest................  564.60s
...bootstrap::core::build_steps::test::TestHelpers...............    0.05s
...bootstrap::core::build_steps::compile::Std....................    0.00s
....bootstrap::core::build_steps::compile::StartupObjects........    0.00s
....bootstrap::core::build_steps::compile::StdLink...............    0.00s
...bootstrap::core::build_steps::tool::Compiletest...............   24.05s
....bootstrap::core::build_steps::tool::ToolBuild................   24.05s
...bootstrap::core::build_steps::test::RemoteCopyLibs............    0.00s
.bootstrap::core::build_steps::test::Crashes.....................    9.20s
..bootstrap::core::build_steps::test::Compiletest................    9.20s
.bootstrap::core::build_steps::test::Coverage....................    9.62s
..bootstrap::core::build_steps::test::Compiletest................    9.62s
...bootstrap::core::build_steps::tool::CoverageDump..............    7.23s
....bootstrap::core::build_steps::tool::ToolBuild................    7.23s
.bootstrap::core::build_steps::test::Coverage....................    3.32s
..bootstrap::core::build_steps::test::Compiletest................    3.32s
.bootstrap::core::build_steps::test::MirOpt......................    5.94s
..bootstrap::core::build_steps::test::Compiletest................    5.94s
...bootstrap::core::build_steps::compile::Std....................    0.00s
.bootstrap::core::build_steps::test::Codegen.....................   11.24s
..bootstrap::core::build_steps::test::Compiletest................   11.24s
.bootstrap::core::build_steps::test::CodegenUnits................    0.85s
..bootstrap::core::build_steps::test::Compiletest................    0.85s
.bootstrap::core::build_steps::test::Assembly....................   10.62s
..bootstrap::core::build_steps::test::Compiletest................   10.62s
.bootstrap::core::build_steps::test::Incremental.................   18.37s
..bootstrap::core::build_steps::test::Compiletest................   18.37s
.bootstrap::core::build_steps::test::Debuginfo...................    8.32s
..bootstrap::core::build_steps::test::Compiletest................    8.32s
...bootstrap::core::build_steps::dist::DebuggerScripts...........    0.00s
.bootstrap::core::build_steps::test::UiFullDeps..................   28.69s
..bootstrap::core::build_steps::test::Compiletest................   28.69s
...bootstrap::core::build_steps::compile::Rustc..................    0.00s
....bootstrap::core::build_steps::compile::RustcLink.............    0.00s
.bootstrap::core::build_steps::test::Rustdoc.....................  278.30s
..bootstrap::core::build_steps::test::Compiletest................  278.30s
...bootstrap::core::build_steps::tool::Rustdoc...................  137.78s
....bootstrap::core::build_steps::tool::ToolBuild................  137.78s
.bootstrap::core::build_steps::test::CoverageRunRustdoc..........    0.60s
..bootstrap::core::build_steps::test::Compiletest................    0.60s
.bootstrap::core::build_steps::test::Pretty......................    1.33s
..bootstrap::core::build_steps::test::Compiletest................    1.33s
.bootstrap::core::build_steps::test::CodegenCranelift............    7.54s
.bootstrap::core::build_steps::test::Crate.......................  453.62s
..bootstrap::core::build_steps::compile::Std.....................    0.41s
...bootstrap::core::build_steps::compile::StdLink................    0.00s
..bootstrap::core::build_steps::tool::Rustdoc....................   63.46s
...bootstrap::core::build_steps::tool::ToolBuild.................   63.46s
.bootstrap::core::build_steps::test::CrateLibrustc...............  223.29s
..bootstrap::core::build_steps::test::Crate......................  223.29s
.bootstrap::core::build_steps::test::CrateRustdoc................   49.60s
.bootstrap::core::build_steps::test::CrateRustdocJsonTypes.......   31.57s
.bootstrap::core::build_steps::test::CrateBootstrap..............    8.88s
..bootstrap::core::build_steps::tool::Rustdoc....................    0.00s
.bootstrap::core::build_steps::test::CrateBootstrap..............    0.42s
.bootstrap::core::build_steps::test::CrateBootstrap..............    5.14s
.bootstrap::core::build_steps::test::CrateBootstrap..............    1.71s
.bootstrap::core::build_steps::test::Linkcheck...................  790.51s
..bootstrap::core::build_steps::doc::UnstableBook................   60.32s
...bootstrap::core::build_steps::doc::UnstableBookGen............    1.63s
....bootstrap::core::build_steps::tool::UnstableBookGen..........    1.55s
.....bootstrap::core::build_steps::tool::ToolBuild...............    1.55s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::UnstableBook>   58.69s
....bootstrap::core::build_steps::tool::Rustbook.................   56.77s
.....bootstrap::core::build_steps::tool::ToolBuild...............   56.77s
..bootstrap::core::build_steps::doc::TheBook.....................    2.19s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::TheBook>    0.68s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::TheBook>    0.05s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::TheBook>    0.09s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::TheBook>    0.09s
...bootstrap::core::build_steps::doc::SharedAssets...............    0.00s
..bootstrap::core::build_steps::doc::Standalone..................    0.49s
..bootstrap::core::build_steps::doc::Std.........................   45.89s
..bootstrap::core::build_steps::doc::Rustc.......................  194.67s
..bootstrap::core::build_steps::doc::Rustdoc.....................   42.02s
..bootstrap::core::build_steps::doc::Rustfmt.....................   32.19s
..bootstrap::core::build_steps::doc::ErrorIndex..................   86.33s
...bootstrap::core::build_steps::tool::ErrorIndex................   85.00s
....bootstrap::core::build_steps::tool::ToolBuild................   85.00s
..bootstrap::core::build_steps::doc::Nomicon.....................    0.17s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::Nomicon>    0.17s
..bootstrap::core::build_steps::doc::Reference...................    2.06s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::Reference>    2.06s
..bootstrap::core::build_steps::doc::RustdocBook.................    0.09s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::RustdocBook>    0.09s
..bootstrap::core::build_steps::doc::RustByExample...............    1.51s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::RustByExample>    1.51s
..bootstrap::core::build_steps::doc::RustcBook...................   21.58s
...bootstrap::core::build_steps::tool::LintDocs..................    4.22s
....bootstrap::core::build_steps::tool::ToolBuild................    4.22s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::RustcBook>    0.53s
..bootstrap::core::build_steps::doc::Cargo.......................  147.63s
..bootstrap::core::build_steps::doc::CargoBook...................    0.50s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::CargoBook>    0.50s
..bootstrap::core::build_steps::doc::Clippy......................   20.18s
..bootstrap::core::build_steps::doc::ClippyBook..................    0.13s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::ClippyBook>    0.13s
..bootstrap::core::build_steps::doc::Miri........................   40.52s
..bootstrap::core::build_steps::doc::EmbeddedBook................    0.14s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::EmbeddedBook>    0.14s
..bootstrap::core::build_steps::doc::EditionGuide................    0.13s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::EditionGuide>    0.13s
..bootstrap::core::build_steps::doc::StyleGuide..................    0.05s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::StyleGuide>    0.05s
..bootstrap::core::build_steps::doc::Tidy........................   14.85s
..bootstrap::core::build_steps::doc::Bootstrap...................   22.63s
..bootstrap::core::build_steps::doc::Releases....................    0.05s
..bootstrap::core::build_steps::doc::RunMakeSupport..............   13.38s
..bootstrap::core::build_steps::doc::BuildHelper.................    1.06s
..bootstrap::core::build_steps::doc::Compiletest.................    9.35s
..bootstrap::core::build_steps::tool::Linkchecker................    0.27s
...bootstrap::core::build_steps::tool::ToolBuild.................    0.27s
.bootstrap::core::build_steps::test::TierCheck...................    0.81s
.bootstrap::core::build_steps::test::RustAnalyzer................   45.66s
.bootstrap::core::build_steps::test::ErrorIndex..................   22.99s
.bootstrap::core::build_steps::test::RustdocBook.................    2.93s
..bootstrap::core::build_steps::test::BookTest...................    2.93s
.bootstrap::core::build_steps::test::UnstableBook................    8.01s
..bootstrap::core::build_steps::test::BookTest...................    8.01s
.bootstrap::core::build_steps::test::RustcBook...................    2.80s
..bootstrap::core::build_steps::test::BookTest...................    2.80s
.bootstrap::core::build_steps::test::LintDocs....................   17.31s
..bootstrap::core::build_steps::doc::RustcBook...................   17.31s
...bootstrap::core::build_steps::doc::RustbookSrc<bootstrap::core::build_steps::doc::RustcBook>    0.54s
.bootstrap::core::build_steps::test::RustdocTheme................    0.44s
..bootstrap::core::build_steps::tool::RustdocTheme...............    0.42s
...bootstrap::core::build_steps::tool::ToolBuild.................    0.42s
.bootstrap::core::build_steps::test::RustdocUi...................   29.77s
..bootstrap::core::build_steps::test::Compiletest................   29.77s
.bootstrap::core::build_steps::test::RustdocJson.................   33.38s
..bootstrap::core::build_steps::test::Compiletest................   33.38s
...bootstrap::core::build_steps::tool::JsonDocCk.................    5.57s
....bootstrap::core::build_steps::tool::ToolBuild................    5.57s
...bootstrap::core::build_steps::tool::JsonDocLint...............    5.55s
....bootstrap::core::build_steps::tool::ToolBuild................    5.55s
.bootstrap::core::build_steps::test::RustInstaller...............   11.56s
.bootstrap::core::build_steps::test::TestFloatParse..............   49.68s
..bootstrap::core::build_steps::tool::TestFloatParse.............   32.68s
...bootstrap::core::build_steps::tool::ToolBuild.................   32.68s
.bootstrap::core::build_steps::test::Bootstrap...................   54.34s
.bootstrap::core::build_steps::test::RunMake.....................  570.92s
..bootstrap::core::build_steps::test::Compiletest................  570.92s
...bootstrap::core::build_steps::tool::RunMakeSupport............    9.58s
....bootstrap::core::build_steps::tool::ToolBuild................    9.58s
...bootstrap::core::build_steps::tool::Cargo.....................  427.87s
....bootstrap::core::build_steps::tool::ToolBuild................  427.87s
--stage 2 test src/tools/cargo --test-args --skip panic_abort_doc_tests
total............................................................  621.93s
.bootstrap::core::build_steps::test::Cargo.......................  621.63s
..bootstrap::core::build_steps::compile::Assemble................    1.99s
...bootstrap::core::builder::Libdir..............................    0.00s
....bootstrap::core::build_steps::compile::Sysroot...............    0.00s
...bootstrap::core::build_steps::llvm::Llvm......................    0.00s
...bootstrap::core::build_steps::compile::Assemble...............    1.03s
....bootstrap::core::builder::Libdir.............................    0.00s
.....bootstrap::core::build_steps::compile::Sysroot..............    0.00s
....bootstrap::core::build_steps::compile::Assemble..............    0.00s
....bootstrap::core::build_steps::compile::Rustc.................    0.48s
.....bootstrap::core::build_steps::compile::Std..................    0.07s
......bootstrap::core::build_steps::compile::StartupObjects......    0.00s
......bootstrap::core::builder::Libdir...........................    0.00s
.......bootstrap::core::build_steps::compile::Sysroot............    0.00s
......bootstrap::core::build_steps::compile::StdLink.............    0.00s
.....bootstrap::core::build_steps::compile::RustcLink............    0.00s
....bootstrap::core::build_steps::compile::CodegenBackend........    0.09s
....bootstrap::core::build_steps::tool::LldWrapper...............    0.11s
.....bootstrap::core::build_steps::tool::ToolBuild...............    0.11s
.....bootstrap::core::build_steps::llvm::Lld.....................    0.00s
....bootstrap::core::build_steps::tool::WasmComponentLd..........    0.21s
.....bootstrap::core::build_steps::tool::ToolBuild...............    0.21s
....bootstrap::core::build_steps::tool::LlvmBitcodeLinker........    0.14s
.....bootstrap::core::build_steps::tool::ToolBuild...............    0.14s
...bootstrap::core::build_steps::compile::Rustc..................    0.46s
....bootstrap::core::build_steps::compile::Std...................    0.11s
.....bootstrap::core::build_steps::compile::StartupObjects.......    0.00s
.....bootstrap::core::build_steps::llvm::Sanitizers..............    0.06s
.....bootstrap::core::build_steps::compile::StdLink..............    0.00s
....bootstrap::core::build_steps::compile::RustcLink.............    0.00s
...bootstrap::core::build_steps::compile::CodegenBackend.........    0.05s
...bootstrap::core::build_steps::tool::LldWrapper................    0.11s
....bootstrap::core::build_steps::tool::ToolBuild................    0.11s
...bootstrap::core::build_steps::tool::WasmComponentLd...........    0.18s
....bootstrap::core::build_steps::tool::ToolBuild................    0.18s
...bootstrap::core::build_steps::tool::LlvmBitcodeLinker.........    0.14s
....bootstrap::core::build_steps::tool::ToolBuild................    0.14s
..bootstrap::core::build_steps::tool::Cargo......................    0.28s
...bootstrap::core::build_steps::tool::ToolBuild.................    0.28s
..bootstrap::core::build_steps::tool::Rustdoc....................    0.21s
...bootstrap::core::build_steps::tool::ToolBuild.................    0.21s

Test results

Test suite Passed ✅ Ignored 🚫 Failed ❌
(stage 0) 130 (100%) 0 (0%) 0 (0%)
(stage 1) 17 (100%) 0 (0%) 0 (0%)
(stage 2) 6 (100%) 0 (0%) 0 (0%)
alloc, alloctests, core, coretests, panic_abort, panic_unwind, proc_macro, profiler_builtins, std, sysroot, test, unwind, coretests, alloctests (stage 1) 12979 (99%) 78 (1%) 0 (0%)
assembly (stage 2) 472 (88%) 63 (12%) 0 (0%)
cargo (stage 2) 3527 (93%) 264 (7%) 0 (0%)
codegen (stage 2) 696 (83%) 142 (17%) 0 (0%)
codegen-units (stage 2) 43 (100%) 0 (0%) 0 (0%)
coverage (stage 2) 186 (98%) 4 (2%) 0 (0%)
coverage-run-rustdoc (stage 2) 1 (100%) 0 (0%) 0 (0%)
crashes (stage 2) 252 (97%) 7 (3%) 0 (0%)
debuginfo (stage 2) 142 (86%) 23 (14%) 0 (0%)
incremental (stage 2) 165 (98%) 4 (2%) 0 (0%)
mir-opt (stage 2) 325 (99%) 4 (1%) 0 (0%)
pretty (stage 2) 81 (96%) 3 (4%) 0 (0%)
run-make (stage 2) 325 (84%) 63 (16%) 0 (0%)
rustc-main, rustc_abi, rustc_arena, rustc_ast, rustc_ast_ir, rustc_ast_lowering, rustc_ast_passes, rustc_ast_pretty, rustc_attr_data_structures, rustc_attr_parsing, rustc_baked_icu_data, rustc_borrowck, rustc_builtin_macros, rustc_codegen_llvm, rustc_codegen_ssa, rustc_const_eval, rustc_data_structures, rustc_driver, rustc_driver_impl, rustc_error_codes, rustc_error_messages, rustc_errors, rustc_expand, rustc_feature, rustc_fluent_macro, rustc_fs_util, rustc_graphviz, rustc_hashes, rustc_hir, rustc_hir_analysis, rustc_hir_pretty, rustc_hir_typeck, rustc_incremental, rustc_index, rustc_index_macros, rustc_infer, rustc_interface, rustc_lexer, rustc_lint, rustc_lint_defs, rustc_llvm, rustc_log, rustc_macros, rustc_metadata, rustc_middle, rustc_mir_build, rustc_mir_dataflow, rustc_mir_transform, rustc_monomorphize, rustc_next_trait_solver, rustc_parse, rustc_parse_format, rustc_passes, rustc_pattern_analysis, rustc_privacy, rustc_query_impl, rustc_query_system, rustc_resolve, rustc_sanitizers, rustc_serialize, rustc_session, rustc_smir, rustc_span, rustc_symbol_mangling, rustc_target, rustc_trait_selection, rustc_traits, rustc_transmute, rustc_ty_utils, rustc_type_ir, rustc_type_ir_macros, stable_mir (stage 1) 2549 (90%) 284 (10%) 0 (0%)
rustdoc (stage 2) 735 (99%) 4 (1%) 0 (0%)
rustdoc-json (stage 2) 144 (100%) 0 (0%) 0 (0%)
rustdoc-json-types (stage 1) 28 (76%) 9 (24%) 0 (0%)
rustdoc-ui (stage 2) 308 (98%) 5 (2%) 0 (0%)
rustdoc:0.0.0 (stage 1) 130 (93%) 10 (7%) 0 (0%)
ui (stage 2) 18500 (99%) 264 (1%) 0 (0%)
ui-fulldeps (stage 2) 64 (100%) 0 (0%) 0 (0%)
Total 41805 (97%) 1231 (3%) 0 (0%)

Test differences

Show 11 test diffs

Stage 2

  • [pretty] tests/pretty/hir-fn-params.rs: [missing] -> pass (J0)
  • [ui] tests/ui/pattern/check-struct-pat-fields-stability-issue-138319.rs: [missing] -> pass (J0)
  • [ui] tests/ui/stability-attribute/check-stability-issue-138319.rs: [missing] -> pass (J0)

Additionally, 8 doctest diffs were found. These are ignored, as they are noisy.

Job group index

  • J0: aarch64-gnu

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output looks good to me

@marcoieni
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 25, 2025

📌 Commit e9ddf54 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants