AST: represent concatenation and (dis)equality operators just like in the syntax. #7248
Conversation
cristianoc
force-pushed
the
ast-binary-ops
branch
from
7c1a037 to
3286c4d
Compare
cristianoc
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 68a9bb4 | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Print RedBlackTreeNoComments.res - time/run |
2.2259943 ms |
2.10057036 ms |
1.06 |
Print Napkinscript.res - time/run |
83.59990272666666 ms |
77.00100409999999 ms |
1.09 |
Print HeroGraphic.res - time/run |
9.245741866666666 ms |
8.775952553333333 ms |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
| But this function argument is expecting: [1;33mstring[0m | ||
| But it's expected to have type: [1;33mstring[0m |
There was a problem hiding this comment.
Is that still a function argument at that pos? If so we're probably missing something minor here.
There was a problem hiding this comment.
That's an interesting case.
1 The logic to recognise string concatenation was already using "++", so it was never firing.
2 Now it fires, but there's no error message for the recognised StringConcat so it falls back to the default.
Added a specific message for string concatenation now, how does it look?
There was a problem hiding this comment.
Oh haha... 😄 My bad. Go for it, we can rephrase later if wanted.
Concatenation:
++instead of^.Disequality:
!=and!==instead of<>and!=.Equality:
==and===instead of=and==.