Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to compile @rescript/react with latest master #7258

Closed
nojaf opened this issue Jan 28, 2025 · 4 comments
Closed

Unable to compile @rescript/react with latest master #7258

nojaf opened this issue Jan 28, 2025 · 4 comments

Comments

@nojaf
Copy link
Collaborator

nojaf commented Jan 28, 2025

% bunx rescript
>>>> Start compiling
Dependency on @rescript/react
rescript: [44/55] src/RescriptReactRouter.cmj
FAILED: src/RescriptReactRouter.cmj

  We've found a bug for you!
  /Users/user/Projects/project/node_modules/@rescript/react/src/RescriptReactRouter.res:157:16-18

  155 ┆ | (list{_, ..._}, list{}) => true
  156 ┆ | (list{aHead, ...aRest}, list{bHead, ...bRest}) =>
  157 ┆   if aHead !== bHead {
  158 ┆     true
  159 ┆   } else {

  The value !== can't be found
  
  Hint: Did you mean == or !=?

rescript: [50/55] src/ReactTestUtils.cmj
FAILED: src/ReactTestUtils.cmj

  We've found a bug for you!
  /Users/user/Projects/project/node_modules/@rescript/react/src/ReactTestUtils.res:105:83-85

  103 ┆ 
  104 ┆ let findBySelectorAndTextContent = (element, selector, content) =>
  105 ┆   querySelectorAll(element, selector)->Js.Array2.find(node => node->te
      ┆ xtContent === content)
  106 ┆ 
  107 ┆ let findBySelectorAndPartialTextContent = (element, selector, content)
      ┆  =>

  The value === can't be found
  
  Hint: Did you mean ==?

rescript: [55/55] src/v3/ReactV3.cmj
FAILED: cannot make progress due to previous errors.
Failure: /Users/user/Projects/rescript/darwinarm64/ninja.exe 
Location: /Users/user/Projects/project/node_modules/@rescript/react/lib/bs
>>>> Finish compiling (exit: 1)
"@rescript/react": "^0.13.0"

Did something recently change with those operators?

@nojaf
Copy link
Collaborator Author

nojaf commented Jan 28, 2025

@cristianoc perhaps related to #7248?

@cristianoc
Copy link
Collaborator

There's already an analysis test that uses that version of rescript react: tests/analysis_tests/tests/package.json
Maybe try cleaning the project and node modules.

@cristianoc
Copy link
Collaborator

Also if you're using a local build version of the compiler, make sure to make lib.

@nojaf
Copy link
Collaborator Author

nojaf commented Jan 29, 2025

Yup, skill issue on my end. Sorry to bother.

@nojaf nojaf closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants