Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST: represent concatenation and (dis)equality operators just like in the syntax. #7248

Merged
merged 6 commits into from
Jan 15, 2025
+314 −264
Merged

AST: represent concatenation and (dis)equality operators just like in the syntax. #7248

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3286c4d
AST: represent concatenation internally as "++" instead of "^".
cristianoc Jan 14, 2025
cda76d2
Represent disequality as `!=` and `!==`.
cristianoc Jan 14, 2025
96ef15c
Represent equality as `==` and `===`.
cristianoc Jan 14, 2025
3000fd4
Update CHANGELOG.md
cristianoc Jan 14, 2025
68a9bb4
Adapt core error test.
cristianoc Jan 15, 2025
14eb6e1
Add error case for string concatenation.
cristianoc Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Update CHANGELOG.md
@cristianoc
cristianoc committed Jan 14, 2025
commit 3000fd4ef0447c02fac66e69748444202e124f6f
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -28,6 +28,7 @@
- AST cleanup: Remove `@res.partial` attribute from the internal representation, and add a flag to untyped and typed ASTs instead. https://github.com/rescript-lang/rescript/pull/7238 https://github.com/rescript-lang/rescript/pull/7240
- AST cleanup: Remove `structure_item_desc.Pstr_class`, `signature_item_desc.Psig_class`, `structure_item_desc.Pstr_class_type`, `signature_item_desc.Psig_class_type`, `structure_item_desc.Tstr_class`, `structure_item_desc.Tstr_class_type`, `signature_item_desc.Tsig_class`, `signature_item_desc.Tsig_class_type` from AST as it is unused. https://github.com/rescript-lang/rescript/pull/7242
- AST cleanup: remove "|." and rename "|." to "->" in the internal representation for the pipe operator. https://github.com/rescript-lang/rescript/pull/7244
- AST cleanup: represent concatenation (`++`) and (dis)equality operators (`==`, `===`, `!=`, `!==`) just like in the syntax. https://github.com/rescript-lang/rescript/pull/7248

# 12.0.0-alpha.7