Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 11.1.4 #7026

Merged
merged 8 commits into from
Sep 10, 2024
Merged

Version 11.1.4 #7026

merged 8 commits into from
Sep 10, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 8, 2024

Cherry picking fixes

cknitt and others added 5 commits September 8, 2024 16:09
* Check for dotdotdot in args

* Check on attribute rather than label

* Add tests

* Fix naming convention

* Update CHANGELOG
…6953)

* Fix parens in unary operator

* Fix parens in binary expr

* Handle underscore sugar application

* Add tests

* Update CHANGELOG
* Handle parens when mod type is a module signature

* Refactor

* Update CHANGELOG

* Add tests

* Handle more edge cases

* Add more test cases from jscomp/test/coercion_module_alias_test.res
* disallow non-variant spreads in variants

* changelog

* undo formatting in changelog

* run make lib

* changelog

* fix

* changelog
# Conflicts:
#	CHANGELOG.md
@cknitt cknitt force-pushed the cherry-pick-11.1.4 branch from d6f0e76 to 401de69 Compare September 8, 2024 14:47
shulhi and others added 3 commits September 8, 2024 16:49
…t-lang#6997)

* Fix comment removed when function signature has type keyword

* Update CHANGELOG
…g#7001)

* Fix parse error on doc comment before "and" in type def

* CHANGELOG
# Conflicts:
#	jscomp/syntax/src/res_core.ml
* Fix tuple coercion

It was only handled for the first arg in the tuple

* Update CHANGELOG
@cknitt cknitt marked this pull request as ready for review September 8, 2024 15:33
@cknitt cknitt requested review from cristianoc and zth September 8, 2024 15:33
@cknitt cknitt changed the title WIP: Version 11.1.4 Version 11.1.4 Sep 8, 2024
@cknitt cknitt requested a review from shulhi September 9, 2024 14:46
@cknitt cknitt merged commit 3d8ca49 into rescript-lang:11.0_release Sep 10, 2024
14 checks passed
@cknitt cknitt deleted the cherry-pick-11.1.4 branch September 10, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants