Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tuple coercion #7024

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Fix tuple coercion #7024

merged 2 commits into from
Sep 8, 2024

Conversation

shulhi
Copy link
Member

@shulhi shulhi commented Sep 7, 2024

Fix #7003.

It was only handled for the first argument in the tuple. This handles for the rest of the args in the tuple.

@cknitt
Copy link
Member

cknitt commented Sep 7, 2024

Nice work! Could you rebase and move the changelog entry to alpha.4?

It was only handled for the first arg in the tuple
@shulhi shulhi force-pushed the fix-tuple-coercion branch from acfeb85 to aab7907 Compare September 8, 2024 06:36
@cknitt cknitt merged commit ded2d06 into rescript-lang:master Sep 8, 2024
20 checks passed
cknitt pushed a commit to cknitt/rescript that referenced this pull request Sep 8, 2024
* Fix tuple coercion

It was only handled for the first arg in the tuple

* Update CHANGELOG
cknitt pushed a commit that referenced this pull request Sep 10, 2024
* Fix tuple coercion

It was only handled for the first arg in the tuple

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type coersion inside tuple
2 participants