Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module printing #6963

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Fix module printing #6963

merged 6 commits into from
Aug 20, 2024

Conversation

shulhi
Copy link
Member

@shulhi shulhi commented Aug 20, 2024

Fix #6936

@shulhi shulhi marked this pull request as draft August 20, 2024 02:06
@shulhi shulhi marked this pull request as ready for review August 20, 2024 04:28
@shulhi shulhi requested a review from cknitt August 20, 2024 04:28
cknitt
cknitt approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@cknitt cknitt merged commit 2745a3c into rescript-lang:master Aug 20, 2024
20 checks passed
cknitt pushed a commit to cknitt/rescript that referenced this pull request Sep 8, 2024
@shulhi @cknitt
Fix module printing (rescript-lang#6963)
d6f0e76 
* Handle parens when mod type is a module signature

* Refactor

* Update CHANGELOG

* Add tests

* Handle more edge cases

* Add more test cases from jscomp/test/coercion_module_alias_test.res
cknitt pushed a commit to cknitt/rescript that referenced this pull request Sep 8, 2024
@shulhi @cknitt
Fix module printing (rescript-lang#6963)
b0a0e1b 
* Handle parens when mod type is a module signature

* Refactor

* Update CHANGELOG

* Add tests

* Handle more edge cases

* Add more test cases from jscomp/test/coercion_module_alias_test.res
cknitt pushed a commit that referenced this pull request Sep 10, 2024
@shulhi @cknitt
Fix module printing (#6963)
3ed3dec 
* Handle parens when mod type is a module signature

* Refactor

* Update CHANGELOG

* Add tests

* Handle more edge cases

* Add more test cases from jscomp/test/coercion_module_alias_test.res
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect printing in coercion_module_alias_test.res
2 participants
@shulhi @cknitt