-
Notifications
You must be signed in to change notification settings - Fork 132
MQE 1970 MFTF release 2.6.0 PR to master #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n functionality - work around MQE-1904
# Conflicts: # src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php
MQE-1379: Fix MFTF custom actions to fully support Codeception dry-ru…
- Fixed conditional - Modified existing conditional to follow same pattern
- Unit test
- static check fix
MFTF 2.5.4 - Master to Dev merge
Fixes a couple 404 links
MQE-1911: --allow-skipped removing test hooks
…en the entity does not exist
…en the entity does not exist
…en the entity does not exist reverted changes
…eration cron required interval (60 seconds)
…en the entity does not exist reverted changes Added unit test
…en the entity does not exist reverted changes fixed unit test
…nused arguments Refactored to read xml content from files directly to avoid flagging arguments due to step removals during merging/extensions.
…nused arguments fixed unit tests
- fix failing tests
- fix review comments
- add verification test
…nused arguments added exception catch for incorrect action group definition
- added 1 more verification test - reduce cli output of deprecated entities
…nused arguments included $$argument.name$$ pattern + fixed unit tests
MQE-1676: Static check for unused arguments in action group.
MFTF deprecation notice attributes
MFTF AWS Secrets Manager - CI Use
MQE-1969: Updated CHANGELOG.md and bumped MFTF package version
KevinBKozan
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing looks out of place, should be good to merge to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Contribution checklist