Skip to content

MQE-1379: Fix MFTF custom actions to fully support Codeception dry-ru… #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 10, 2019
Merged

MQE-1379: Fix MFTF custom actions to fully support Codeception dry-ru… #516

merged 9 commits into from
Dec 10, 2019

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Nov 27, 2019

…n functionality

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Dec 2, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.6%) to 51.841% when pulling 5fd746c on MQE-1379 into 580d6dc on develop.

KevinBKozan
KevinBKozan suggested changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback; I think I'm missing some important parts of this, feel free to point out the portions I'm overlooking!

KevinBKozan
KevinBKozan suggested changes Dec 3, 2019
View reviewed changes
@KevinBKozan
Copy link
Contributor

@jilu1 One more note, the generateDate action does not show up in dry-run (it's a similar case of not being a native $I action. It should be easy to fix this.

@jilu1
Copy link
Contributor Author

jilu1 commented Dec 4, 2019

"generateDate" will generate built in php functions. It won't break the dry run. I think it will behave the same as Codeception as it's now.

@jilu1
Merge remote-tracking branch 'origin/develop' into MQE-1379
f5dfd24 
# Conflicts:
#	src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php
tomreece
tomreece reviewed Dec 9, 2019
View reviewed changes
tomreece
tomreece approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@tomreece tomreece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jilu1 jilu1 merged commit 342c6f7 into develop Dec 10, 2019
@jilu1 jilu1 deleted the MQE-1379 branch February 6, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomreece tomreece tomreece approved these changes

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jilu1 @coveralls @KevinBKozan @tomreece