-
Notifications
You must be signed in to change notification settings - Fork 132
MFTF deprecation notice attributes #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes requested around constants, logic seems good otherwise.
...gento/FunctionalTestingFramework/DataGenerator/Handlers/OperationDefinitionObjectHandler.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/DataObjectHandler.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Page/Handlers/PageObjectHandler.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Page/Handlers/SectionObjectHandler.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Page/Handlers/SectionObjectHandler.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Test/Util/ActionGroupObjectExtractor.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/Test/Util/TestObjectExtractor.php
Outdated
Show resolved
Hide resolved
- fix failing tests
- fix review comments
- add verification test
@okolesnyk Feature is still printing out all deprecated entities on generation; we need to either:
Option one is easier, and works to reduce noise. I think that once we implement this, the deprecated warning will literally always be up once it starts being used, so I actually think we can supress all deprecated test file warnings. |
$sectionDeprecated = $sectionData[self::OBJ_DEPRECATED] ?? null; | ||
|
||
if ($sectionDeprecated !== null) { | ||
LoggingUtil::getInstance()->getLogger(ElementObject::class)->deprecation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed on first review, should be SectionObject::class
I believe.
- added 1 more verification test - reduce cli output of deprecated entities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, verification tests look thorough, not concerned about manual test requirements.
Description
Fixed Issues (if relevant)
Contribution checklist