Added test cases for BST deletion #66 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokdey
requested changes
Oct 12, 2019
Comment on lines
+8
to
+18
| it('should create BST', () => { | ||
| // Creates BST | ||
| bst = new BinarySearchTree(6); | ||
| bst.add(4); | ||
| bst.add(9); | ||
| bst.add(2); | ||
| bst.add(5); | ||
| bst.add(8); | ||
| bst.add(12); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
@balajipachai how you are checking that the tree is created the way you wanted to create it? You have only added nodes, haven't verified that the nodes are added properly to the tee.
For that, you have to verify any of the traversal output.
|
I will look into it and update the PR |
ashokdey
changed the title
ashokdey
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test cases for BST deletion #66