-
Notifications
You must be signed in to change notification settings - Fork 268
Added test cases for BST deletion #66 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ashokdey
merged 2 commits into
knaxus:master
from
balajipachai:test-cases-for-bst-deletion
Oct 17, 2019
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
51 changes: 51 additions & 0 deletions
51
src/_DataStructures_/Trees/BinarySearchTree/bst-deletion.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
const BinarySearchTree = require('./index'); | ||
const heightOfBST = require('./height-of-bst/index'); | ||
|
||
describe('Binary search tree traversals', () => { | ||
let bst; | ||
|
||
describe('Creates BST', () => { | ||
it('should create BST', () => { | ||
// Creates BST | ||
bst = new BinarySearchTree(6); | ||
bst.add(4); | ||
bst.add(9); | ||
bst.add(2); | ||
bst.add(5); | ||
bst.add(8); | ||
bst.add(12); | ||
}); | ||
}); | ||
|
||
describe('Check bst was created as expected', () => { | ||
it('Inorder traversal of the created bst should be [ 2, 4, 5, 6, 8, 9, 12 ]', () => { | ||
expect(bst.traverseInorder()).toEqual([2, 4, 5, 6, 8, 9, 12]); | ||
}); | ||
|
||
it('Preorder traversal of the created bst should be [ 6, 4, 2, 5, 9, 8, 12 ]', () => { | ||
expect(bst.traversePreorder()).toEqual([6, 4, 2, 5, 9, 8, 12]); | ||
}); | ||
|
||
it('Postorder traversal of the created bst should be [ 2, 5, 4, 8, 12, 9, 6 ]', () => { | ||
expect(bst.traversePostorder()).toEqual([2, 5, 4, 8, 12, 9, 6]); | ||
}); | ||
}); | ||
|
||
describe('BST node deletions', () => { | ||
it('should check height of bst to be 3 prior deletion', () => { | ||
expect(heightOfBST(bst.root)).toEqual(3); | ||
}); | ||
|
||
it('deleting leaf element does not affect tree height if it has sibling', () => { | ||
bst.remove(2); | ||
bst.remove(8); | ||
expect(heightOfBST(bst.root)).toEqual(3); | ||
}); | ||
|
||
it('deleting leaf element does affect tree height if it has no-sibling', () => { | ||
bst.remove(5); | ||
bst.remove(12); | ||
expect(heightOfBST(bst.root)).toEqual(2); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balajipachai how you are checking that the tree is created the way you wanted to create it? You have only added nodes, haven't verified that the nodes are added properly to the tee.
For that, you have to verify any of the traversal output.