Skip to content

Add unit test for BST deletion #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ashokdey opened this issue Oct 11, 2019 · 4 comments
Closed

Add unit test for BST deletion #66

ashokdey opened this issue Oct 11, 2019 · 4 comments
Labels
beginner friendly

Comments

@ashokdey
Copy link
Member

Hello folks, please go through the Contribution Guide here https://github.com/knaxus/problem-solving-javascript#contribution-guide before going forward with this issue.

Thanks
@iamshadmirza iamshadmirza mentioned this issue Oct 11, 2019
Merged
@iamshadmirza
Copy link
Contributor

iamshadmirza commented Oct 11, 2019 •
edited
Loading

I'll need a little help with this PR @ashokdey . I'm not sure I followed the right coding convention for writing tests. Please review

@balajipachai balajipachai mentioned this issue Oct 11, 2019
Merged
@iamshadmirza iamshadmirza mentioned this issue Oct 14, 2019
Merged
@ashokdey
Copy link
Member Author

@iamshadmirza can you refer the PR here? Which PR you are exactly taking about?

@iamshadmirza
Copy link
Contributor

Both are reviewed and merged successfully. They were #67 for insert() test and #86 for delete() test for BST.

@TheSTL
Copy link
Member

TheSTL commented Oct 15, 2019

Closing this issue.
Merged PR - [#86 ]

@TheSTL TheSTL closed this as completed Oct 15, 2019
ashokdey added a commit that referenced this issue Oct 17, 2019
@ashokdey
Merge pull request #73 from balajipachai/test-cases-for-bst-deletion
fb4feb4 
Added test cases for BST deletion #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashokdey @iamshadmirza @TheSTL