Disable test_autodebug for V8 #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_autodebug is inaccurately marked no_wasm_backend(), when really it doesn't work in v8, with either backend or asm2wasm. v8 does work with asmjs, but just banning v8 is more accurate than not disabling this test for asm2wasm.
kripken
approved these changes
Oct 18, 2016
| def test_autodebug(self): | ||
| self.banned_js_engines = [V8_ENGINE] # Broken on V8 but not node; wasm-only |
There was a problem hiding this comment.
if this is wasm-only, then this could be if self.is_wasm(): and then your new line. then we'd still test v8 on the asm.js version.
|
Best of both worlds |
|
Thanks. One last thing - is there a v8 bug open for this? If so would be nice to add the URL in the comment. |
|
Realized I forgot to follow up on this: I don't think there's a V8 bug open, though to be honest I'm not entirely sure what's causing the breakage. Meanwhile the change as it was didn't actually cause the test to not-fail, because it would trip on the asserts immediately afterward. 96fc2c4 should address that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_autodebug is inaccurately marked no_wasm_backend(), when really it
doesn't work in v8, with either backend or asm2wasm.
v8 does work with asmjs, but just banning v8 is more accurate than not
disabling this test for asm2wasm.
We'd like to test asm2wasm against the emscripten testsuite on the wasm waterfall using v8, and this is the only failing test in that case.