Disable test_autodebug for V8 (#4633)

* Disable test_autodebug for V8

test_autodebug is inaccurately marked no_wasm_backend(), when really it
doesn't work in v8, with either backend or asm2wasm.
v8 does work with asmjs, but just banning v8 is more accurate than not
disabling this test for asm2wasm.

* Exit early in autodebug when only running with V8

Author: jgravelle-google

tests/runner.py

@@ -605,6 +605,17 @@ def setup_runtimelink_test(self):
     '''
     return (main, supp)
 
+  def filtered_js_engines(self, js_engines=None):
+    if js_engines is None:
+      js_engines = JS_ENGINES
+    for engine in js_engines: assert type(engine) == list
+    for engine in self.banned_js_engines: assert type(engine) == list
+    js_engines = filter(lambda engine: engine[0] not in map(lambda engine: engine[0], self.banned_js_engines), js_engines)
+    if 'BINARYEN_METHOD="native-wasm"' in self.emcc_args:
+      # when testing native wasm support, must use a vm with support
+      js_engines = filter(lambda engine: engine == SPIDERMONKEY_ENGINE or engine == V8_ENGINE, js_engines)
+    return js_engines
+
   def do_run_from_file(self, src, expected_output, args=[], output_nicerizer=None, output_processor=None, no_build=False, main_file=None, additional_files=[], js_engines=None, post_build=None, basename='src.cpp', libraries=[], includes=[], force_c=False, build_ll_hook=None, extra_emscripten_args=[]):
     self.do_run(open(src).read(), open(expected_output).read(),
                 args, output_nicerizer, output_processor, no_build, main_file,
@@ -626,14 +637,7 @@ def do_run(self, src, expected_output, args=[], output_nicerizer=None, output_pr
                  build_ll_hook=build_ll_hook, extra_emscripten_args=extra_emscripten_args, post_build=post_build)
 
     # Run in both JavaScript engines, if optimizing - significant differences there (typed arrays)
-    if js_engines is None:
-      js_engines = JS_ENGINES
-    for engine in js_engines: assert type(engine) == list
-    for engine in self.banned_js_engines: assert type(engine) == list
-    js_engines = filter(lambda engine: engine[0] not in map(lambda engine: engine[0], self.banned_js_engines), js_engines)
-    if 'BINARYEN_METHOD="native-wasm"' in self.emcc_args:
-      # when testing native wasm support, must use a vm with support
-      js_engines = filter(lambda engine: engine == SPIDERMONKEY_ENGINE or engine == V8_ENGINE, js_engines)
+    js_engines = self.filtered_js_engines(js_engines)
     if len(js_engines) == 0: return self.skip('No JS engine present to run this test with. Check %s and the paths therein.' % EM_CONFIG)
     if len(js_engines) > 1 and not self.use_all_engines:
       if SPIDERMONKEY_ENGINE in js_engines: # make sure to get asm.js validation checks, using sm

tests/test_core.py

@@ -5740,9 +5740,14 @@ def do_autodebug_post(self, filename):
     Building.llvm_as(filename)
     Building.llvm_dis(filename)
 
-  # Broken on V8 but not node
-  @no_wasm_backend()
   def test_autodebug(self):
+    if self.is_wasm():
+      # Broken on V8 but not node; wasm-only
+      self.banned_js_engines = [V8_ENGINE]
+      if not self.filtered_js_engines():
+        # Return early to not run into asserts
+        return self.skip('wasm on V8 currently fails')
+
     if Building.LLVM_OPTS: return self.skip('LLVM opts mess us up')
     Building.COMPILER_TEST_OPTS += ['--llvm-opts', '0']