Skip to content

Disable test_autodebug for V8 #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2016
Merged

Disable test_autodebug for V8 #4633

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a8f53f
Disable test_autodebug for V8
jgravelle-google Oct 18, 2016
85e1ec1
Ban V8 on test_autodebug for wasm only
jgravelle-google Oct 18, 2016
96fc2c4
Exit early in autodebug when only running with V8
jgravelle-google Oct 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ban V8 on test_autodebug for wasm only
  • Loading branch information
@jgravelle-google
jgravelle-google committed Oct 18, 2016
commit 85e1ec1c7678d31c44aa1d5648529291cdeb81e0
4 changes: 3 additions & 1 deletion tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5741,7 +5741,9 @@ def do_autodebug_post(self, filename):
Building.llvm_dis(filename)

def test_autodebug(self):
self.banned_js_engines = [V8_ENGINE] # Broken on V8 but not node; wasm-only
if self.is_wasm():
# Broken on V8 but not node; wasm-only
self.banned_js_engines = [V8_ENGINE]
if Building.LLVM_OPTS: return self.skip('LLVM opts mess us up')
Building.COMPILER_TEST_OPTS += ['--llvm-opts', '0']

Expand Down