This repository was archived by the owner on Sep 30, 2019. It is now read-only.
SPI Methods: Prevention of hardware limit errors and data corruption #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying fixes described here: adafruit#94 adafruit#95 In order to: Prevent a data stream larger than 64 KB from passing per command and warn the user Fix the weird data corruption error that may or may not occur from full hardware limit length reads
mcprat
changed the title
|
@ladyada let me know what you think of these pull requests when you have time. This is my last pull request for now. I would say this portion of the library for SPI is perfect after these couple changes. Thanks |
ladyada
approved these changes
Mar 29, 2019
|
oof theres a conflict, can you rebase/fix and then i can merge? |
|
mmmmm.... I'm still kind of new to github...I'll figure it out tomorrow |
|
lol no biggie :) thank you! |
|
@ladyada Alright...I did a merging commit and it looks good Thanks a lot for the quick replies |
mcprat
pushed a commit
to mcprat/Adafruit_Python_GPIO
that referenced
this pull request
Apr 2, 2019
Fix mistakes from adafruit#98 This time, extensively tested Also added support for read requests of odd length, read requests of length 1 working Also applied same ideas to write requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying fixes described here to the other SPI methods:
#94
#95
In order to:
Prevent a data stream larger than 64 KB from passing per command and warn the user
Fix the weird data corruption error that may or may not occur from full hardware limit length reads