This repository was archived by the owner on Sep 30, 2019. It is now read-only.
Fix mistakes from previous pull request for SPI methods #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 2, 2019 00:03
Fix mistakes from adafruit#98 This time, extensively tested Also added support for read requests of odd length, read requests of length 1 working Also applied same ideas to write requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mistakes from #98
This time, extensively tested
largest mistake was: didnt replace spi. with self. in method calls inside the method
Also added support for read requests of odd length, read requests of length 1 working
Also applied same ideas to write requests