This repository was archived by the owner on Sep 30, 2019. It is now read-only.
Fixed PWM driver reset #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er initialization.
…. In the old version any subsequent board initialization reset all previously initialized boards.
|
Thanks for submitting the changes--just tested them out and they work great. Merging the changes in now. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation only set the
MODE1register to0x00, which is not the default of the PCA9685 (bit 0,ALLCALL, defaults to 1 - see section 7.3.1 in the datasheet) and ignores all other register likeMODE2, all output values, etc. The PCA9685 offers a dedicated software reset, which "allows all the devices in the I2C-bus to be reset to the power-up state" (section 7.6).