GWWST-139 Inaccuracy in color temp due to unit conversion/rounding #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the math to round instead of truncate, which mirrors the operation in appengine-zigbee and should get us slightly more accurate numbers.
tpmanley
previously approved these changes
Jan 11, 2018
Based on feedback, product would prefer if we fudged the numbers a bit so that K values match what is set by the user.
…nding" This reverts commit 702229d.
Contributor
|
Math.round is not the same as |
Contributor
Author
|
@workingmonk |
Contributor
|
👍 |
Contributor
Author
|
Approvals on this PR lol |
workingmonk
approved these changes
Jan 17, 2018
Contributor
|
i am guessing you already addressed the issues that Tom pointed out |
mmalik76
added a commit
to mmalik76/SmartThingsPublic
that referenced
this pull request
Mar 1, 2018
* [DHF-61] Exponentially pings offline Z-Wave Switches * [DHF-58] Exponentially pings offline Z-Wave Water Valve * [DHF-59] Exponentially pings offline Z-Wave Garage Door Opener * [DHF-64] Exponentially pings offline Inovelli Smart Plug * [DHF-63] Exponentially pings offline FortrezZ Water Valve * DVCSMP-3334 - Harmony NullPointerException (HOTFIX) * [DVCSMP-2740] [DVCSMP-3330] [DVCSMP-3322] Yale Zigbee - Locked / unlocked by master code event is not displayed. Yale Zigbee lock - Unable to create the user code from Smart lock app in previously deleted user code slot. * MSA-2127: Fibaro Door/ Window 2 is a new contact sensor that was released in Europe in June 2017 and will be released in the USA on August 1st. D/W 2 has integrated temperature sensor and we revised how parameters are adjusted. * Add the runLocally flag to new local running DTHs This adds the flag to allow the newly supported DTHs to run locally. * [DVCSMP-3206] Adding Fix for Aeon Labs Panic Button and Aeon Key Fob * PROB-1673 Don't use defaultValue and required in the preferences block * [DVCSMP-3355] [DVCSMP-3352] [DVCSMP-3353] [DVCSMP-3356] Kwikset Z-wave - Description text is displayed as "Locked by Master code" when lock is locked using 'Lock' button. Yale Z-wave - Incorrect state is shown for Unlock event in DTH when Autolock is enabled. Yale Zigbee lock- State is not changed in the DTH after locking via app when Auto Lock is ON. Change "Locked/Unlocked via app" to "Locked/Unlocked". * [ICP-2051] Added new fingerprint for YRD221 models of older generation in Chile. Without the fingerprint the models of older generation will not be onboarded with device type as Zigbee Lock. * PROB-1869 Zen thermostat connecting with no battery state (SmartThingsCommunity#2424) * PROB-1869 Zen thermostat connecting with no battery state Changing max allowed battery voltage from 6.0 to 6.1 as logs from a user showed the thermostat reporting 6.1V despite there's only 4 x 1.5V batteries. Also made a change so that thermostatMode and fanMode only generate an event when the mode is changing. * Update zen-thermostat.groovy * Remove unused polling capabilities * [DVCSMP-3377] Schlage Locks - For some locks DTH is assigning default code name instead of code name provided by user. * DVCSMP-3283 Adding blacklisted DTH to catch bad devices (SmartThingsCommunity#2371) * DVCSMP-3283 Adding blacklisted DTH to catch bad devices * Adding correct support link * Added curb bridge to smartthingspublic (SmartThingsCommunity#2346) * Added curb bridge to smartthingspublic * untabified, appsettings used * switched to 1 minute interval * took out historical data * took out a rouge } * Added Energy Monitor with load controller and thermostat controls * added historical again, added refresh tokens, added better state restore logic * switches intelligently generate default values * syntax error * typo * it works! * fixed the error messages popping up in the live logging window * added 1m resolution, got rid of erraneous error messages * took out unnecessary debug messages * added all the different energy timeintervals * finishing touches on the curb app * Took out a debug statement * reduced api endpoints to only have single power/energy values * tabs to spaces * fixed atomicstate looping * DVCSMP-3384 Add tile type to multi attribute tile for devices * Add the runLocally flag to Z-Wave Generic DTHs * DVCSMP-3374 Zen Thermostat has no settings for "Heat only" or "Cool only" (SmartThingsCommunity#2503) A customer reported on PR 2296; "My Zen can only Heat (10A setting I think). There is no option for "Off, Heat" in the thermostat modes settings UI." Adding ["off", "heat"] and ["off", "cool"] to settings. * DVCSMP-3283 - Blacklisted Device Link to Support fingerprints install * DVCSMP-690 (SmartThingsCommunity#2483) * DVCSMP-690 Aeon multisensor improvements * Removes the configure tile. * Configuration commands should now be sent on wake-up, until a temperature report is sent * Added preferences to configure the motion timeout and the reporting interval. Defaults are 20s and 5min * Send an association remove during configuration to prevent double reports * Removes the battery from the sensor reporting group. It now reports every 12 hours * Renamed/reworked preferences to more closely match aeon-multisensor-6 * Configuration will now happen on preference update or wakeup if it hasn't happened yet * Added some extra description text to the configuration preferences. * [ICP-2233] During scanning of Lock Codes, Recently tab shows multiple events for added lock codes. * DVCSMP-2220 Aeon Siren not sending alert on secure inclusion failure (SmartThingsCommunity#2511) This just cribs the way other secure devices handle this failure. In the future we'd like to have this standardized or done automatically. * [DVCSMP-3396] Locks DTH should generate event for changed and unset during scanning. * ICP-2082: Set initial state of Z-Wave Switch Generic * Adding changeable icons back to zwave-relay and momentary-button-tile DTHs In a recent update to change these DTHs to use multi-attribute tiles the option to change the device icon for them was lost. This has caused a few users to not be able to change icons on devices that they could before (PROB-1904). This change adds back the ability to change the icons for these two device types. * ICP-2151, ICP-2236, ICP-2237 Add Samsung Lock fingerprint to DTH Give generic name to handle different locks with the same fingerprint * [DVCSMP-2677] Change in DTH for device join name to reflect Aeotec from Aeon Labs * DVCSMP-690 Aeon multisensor improvements (SmartThingsCommunity#2549) * DVCSMP-690 Aeon multisensor improvements Fixes major oversight where commands would not be handled. * DVCSMP-690 Aeon multisensor improvements Bundles configuration and wakeup commands into one multiAction * [ICP-2350], [ICP-2309]: Yale Keyless Connected Smart Door Lock pair as Z-Wave Lock. Yale YRD216 Lock pair as Z-Wave Lock. * SAPLAT-81 Additional fingerprint for Inovelli 2-channel smart plug * ICP-2151, ICP-2236, ICP-2237 *READD* Samsung Digital Lock fingerprint Add comments to fingerprint list breaking out fingerprints by manufacturer for readability Update README with added models * DVCSMP-3412 Utilize sunrise/sunsetTime instead of external API * Revert "DVCSMP-690 Aeon multisensor improvements (SmartThingsCommunity#2549)" This reverts commit 5ee4cec. * Revert "DVCSMP-690 (SmartThingsCommunity#2483)" This reverts commit 4619c13. * Mark 0.20.X devices to run locally This is marking the hubcore 0.20.X newly supported devices to run locally. This resolves: https://smartthings.atlassian.net/browse/CHAD-1633 * Add mfr fingerprints to Fibaro Motion NVS-6 * DVCSMP-3349 Use old reporting logic for older firmware Centralite sensors * Update zigbee fingerprints for sengled Add Sengled E12-N15 to zigbee dimmer DTH Reorder zigbee fingerprinting lines alphanumerically. * NQA-793 - Thermostat automation support (SmartThingsCommunity#2614) Small typos small change * DVCSMP-1524 Remove polling capability from hub-polled devices (SmartThingsCommunity#2510) Removes the deprecated polling capability from these devices which are polled by the hub directly. * Add Sengled RGBW to zigbee-rgbw-bulb.groovy * Update deviceJoinName for zigbee-rgbw-bulb.groovy * [DVCSMP-3494] Some schlage locks read "Unlocked by Master Code" when unlocked with a user code. * Dvcsmp-1437 GE Fan switches don't support configuration (SmartThingsCommunity#2626) * DVCSMP-1437 GE Fan switches don't support indicator LED control Move the GE Fan switch to the generic dimmer handler, since they don't support the configuration options of the other GE dimmers. * ICP-1827 Yale Assure Lock device join name fix (SmartThingsCommunity#2630) The two models of Yale Assure Lock (w/ and w/o BT) are indistinguishable based on ZWave info. This makes the name applicable to both models. * Add Sengled Element Plus to zigbee-white-color-temperature-bulb * Honeywell dimmer and switch fingerprints (SmartThingsCommunity#2631) WWST-159 WWST-155 WWST-164 WWST-157 WWST-166 WWST-158 WWST-156 WWST-165 WWST-160 WWST-167 WWST-170 Add fingerprints for Honeywell dimmers and switches. WWST-162 Dimmer switches also not polling for initial status This adds an initial poll on install like we have for (non-dimmer) zwave switches. * PROB-1940 Ecobee Thermostat Automation Setpoint off by 1 Degree When an automation sends a setpoint to an ecobee thermostat that matches the current setpoint, the setpoint changes by 1 degree. This issue was caused by the need of forcing the new setpoint +-1° when rounding issues between °F and °C caused the setpoint to remain the same when changing it manually one step at a time. Added fix to check if setpoints are set manually or by automation before applying the +-1° adjustment. Also added possibility to change the deadband used in device settings. * DVCSMP-1437 GE Fan switch does not support configuration (SmartThingsCommunity#2638) Fixes typo in model number. * [ICP-1827] YALE 256 - Device pairing name is wrong. (SmartThingsCommunity#2640) * WWST-159 WWST-155 WWST-164 WWST-157 WWST-166 WWST-158 WWST-156 WWST-165 WWST-160 WWST-167 (SmartThingsCommunity#2643) Honeywell binary switched were put in the wrong DTH. Should go in the generic one instead of the one meant for GE devices. * ICP-2367 Yale Locks send lock operations before notification events (SmartThingsCommunity#2627) * ICP-2367 Yale Locks send lock operations before notification events We need to enforce the order of notification and lock in order to get the most information possible for the lock/unlock events. This attempts to delay the lock command event until after the notification event. Because if isStateChange, the lock event will actually essentially get ignored as long as the notification event comes. This should delay the calling of createEvent on the doorLockOperation data so that the isStateChange flag should be set how we expect it to be. Cleaning up some of the code and adding a debug log for this rare event. * ICP-2506 Yale has fixed their battery reporting Adds a specific model check for older Yale devices that report their battery values incorrectly. * [CHAD-1649] Temporary Fix to clear tamper * Tamper is cleared after 10s of it being detected This is because tamper is not handled locally * ICP-2750 - State after cutting off power 2** check * Changes made as per the ticket * ICP-2947 - HOTFIX - Remove invalid token Update Update2 * PROB-1869 Zen thermostat connecting with no battery state (SmartThingsCommunity#2671) * PROB-1869 Zen thermostat connecting with no battery state Changing algorithm for calculating battery % so it no longer need the check for upper/lower limit of the received voltage. * Update zen-thermostat.groovy * GWWST-139 Inaccuracy in color temp due to unit conversion/rounding (SmartThingsCommunity#2691) * GWWST-139 Inaccuracy in color temp due to unit conversion/rounding This changes the math to round instead of truncate, which mirrors the operation in appengine-zigbee and local execution and should get us slightly more accurate numbers. * Remove Simulated devices from running locally As a part of the customer beta we ran into a number of different issues with regards to simulated switches running locally. We have decided to remove them from running locally in 20.X and target 21.X which may use this, or a different DTH after discussing options. * ICP-2954 Fingerprints for Yale Conexis (SmartThingsCommunity#2707) * ICP-2954 Fingerprints for Yale Conexis * ICP-2750 - State after cutting off power 2.0 Update * [LSD-204] Adding pausable and usesThirdPartyAuthentication to SmartApp definitions * ICP-2261 - LIFX translated (SmartThingsCommunity#2724) Update * ICP-2850 Setting color temperature causes offline device to come online (SmartThingsCommunity#2729) The event generated by setting the color name is causing devices to be marked online. Changes the zll rgbw bulb to match the zigbee rgbw bulb in terms of how it handles color temperature. * GWWST-84 Fibaro Flood Sensor reports fractional temp (SmartThingsCommunity#2733) Just overwriting the precision from this device to force it to be an integer to match other devices. * DVCSMP-2959: Fibaro Door/Window 2 onboarding Updated some event values for consistency with other Fibaro DTH Changed some code style to also match other Fibaro DTH Added initial state events Set logging enabled by default ICP-2763 Fibaro Door/Window 2 does not go offline: The checkInterval was only being set if the device received a wakeup notification. If the batteries were removed before the first wakeup (i.e. before device configuration) there would be no checkInterval set. * DVCSMP-2807 GWWST-77: Z-Wave Metering Switch (Secure) for support for the Fibaro Smart Switch ZW5 (SmartThingsCommunity#2353) * [DVCSMP-3320]. Support for light bulbs. (SmartThingsCommunity#2439) * DVCSMP-3320. Support for light bulbs. * DVCSMP-3320. Removing profileId from fingerprint. * [LSD-203] Adding CO2 Vent to set flags on the definitions * PROB-1941 Smart Care apps missing Save button on iOS (SmartThingsCommunity#2737) The definition for the page in the preferences section did not specify 'install: true', instead this was specified in the declaration for the dynamicPage. However, it seems changing the definition in the dynamic page declaration doesn't matter as in iOS it always uses the first declaration found. Fixing this issue by adding 'install: true' to the preference declaration and removing the page definition from dynamicPage. * ICP-3086 remove SMS option * ICP-2939 Initial battery poll being ignored (SmartThingsCommunity#2721) This is purely a timing issue caused by secure commands creating a bit of a logjam. This is the lowest value that SR-Pol was reliably able to get a battery report with. * DVCSMP-2874 Aeon multisensor 6 missing method exception (SmartThingsCommunity#2604) Bundles configuration and wakeup commands into one multiAction Changes the checkInterval to match the user-set report interval. Changes ping to use temperature as ping will only work when the device is on ac power, so a battery poll would be not as useful. Changes the checkinterval update to happen inside configure in cases where the device is in wakeup mode so that we don't change the check interval without changing the report interval. Fixes a typo in the time lookup table. * IPB-272 - Door knocker to Spanish * [CHAD-1649] Temporary Fix to clear tamper * Tamper is cleared after 10s of it being detected This is because tamper is not handled locally * ICP-3087 YRD 216 Zigbee missing device fingerprints (SmartThingsCommunity#2739) * ICP-3086 remove SMS option (fixes) * ICP-3135 Wrong icon type for smart plug in SC (SmartThingsCommunity#2747) the switch device type gets a switch icon, but this is a plug so it needs the plug icon * ICP-2818 Sengled bulbs pair at level "1" as well Adding 'sengled' to the list of manufacturers for which we fabricate a level 100 report on add. * PROB-1987 Fix tile type * ICP-3189: Add OSRAM SMART+ Plug fingerprint While this device is a ZLL device, it does work with the ZHA DTH. * Fix exception in Z-Wave fallback types DVCSMP-3560 * ONEAPP-1122 zigbee RGB bulb missing ocf icon (SmartThingsCommunity#2765) * Revert "DVCSMP-3412 Utilize sunrise/sunsetTime instead of external API" This reverts commit 787ef7d. * Variable not defined for CT command * ICP-3342 - Remove SMS * Adds privileged: true Add dynamic pages * DEVC-574 Reduce color temp steps to 50 Kelvin * reduced step size from 500K to 50K. * PROB-1226 - Re authenticate account * DVCSMP-3566 Remove blacklisted Kwikset Smartcode lock (SmartThingsCommunity#2789) * Fingerprints for directly connected Hue lights (SmartThingsCommunity#2787) Although not officially certified or supported many users connect Hue lights directly to the SmartThings hub and most of the type they join as Things. This adds fingerprints for most of the models listed in: https://developers.meethue.com/documentation/supported-lights. https://smartthings.atlassian.net/browse/DVCSMP-3567 * PROB-1824: Add more LEDVANCE/OSRAM/SYLVANIA products (SmartThingsCommunity#2785) * ICP-3342 - Fix dynamic page * Rolling up staging to production (SmartThingsCommunity#2798) * Fix exception in Z-Wave fallback types DVCSMP-3560 * ONEAPP-1122 zigbee RGB bulb missing ocf icon (SmartThingsCommunity#2765) * ICP-3342 - Remove SMS * Adds privileged: true Add dynamic pages * DEVC-574 Reduce color temp steps to 50 Kelvin * reduced step size from 500K to 50K. * PROB-1824: Add more LEDVANCE/OSRAM/SYLVANIA products (SmartThingsCommunity#2785) * ICP-3342 - Fix dynamic page * [LSD-204] Adding definition flags to IFTTT (SmartThingsCommunity#2800) * DVCSMP-3566 Adding profile id for kwikset locks (SmartThingsCommunity#2791) * Report correct status when locked via keypad (SmartThingsCommunity#2781) Schlage and Yale, with One Touch locking enabled are locked manually from the keypad, report the status correct to differentiate manual locking and keypad locking * Provide new virtual switches for local execution (SmartThingsCommunity#2807) This adds a pair of new Virtual Switch device types that can execute locally. This allows us to avoid breaking existing functionality while providing exactly the functionality that we want. * ICP-3154 Locks not responsive in Poland (SmartThingsCommunity#2809) Similar to the battery change a month ago, command backups were causing commands to be sent to quickly to Yale locks, causing them to get wedged. * Add support for 0.21.X locally running devices (SmartThingsCommunity#2812) This is a part of: https://smartthings.atlassian.net/browse/CHAD-1389 * MKTP-1186 - SendEvent Switch to support SC (SmartThingsCommunity#2813) * PROB-1824 Add newer LEDVANCE Sylvania BR30 and RT5/6 tunable white (SmartThingsCommunity#2810) * SAPLAT-96 Virtual Device Manager to create virtual devices from the app (SmartThingsCommunity#2808) * SAPLAT-96 Virtual Device Manager to create virtual devices from the app * SAPLAT-96 SingleInstace param for smartapp missing (SmartThingsCommunity#2822) * Modified runCall function * DVCSMP-3298 Add state labels to Fibaro sensors that were missing them. (SmartThingsCommunity#2832) * Add fingerprint for Sengled RGBW (SmartThingsCommunity#2825) DVCSMP-3503 Add fingerprint for Sengled RGBW * Added UV Capability, humidity icon, sync time stamp * Remove Humidity icon (for iOS) * WWST-131 Added fingerprint Aeotec Smart Dimmer 6 * Icp 3837 Add/Update fingerprints for Ikea TRÅDFRI Smart Bulbs (SmartThingsCommunity#2837) * ICP-3837 Add/Update fingerprints for Ikea TRÅDFRI Smart Bulbs Whitespace conversion from spaces to Tabs Ikea bulbs deviceJoinName changes Add 3 new fingerprint for Ikea bulbs * Added support for Eaton Master Switch [DEVC-567] and Eaton Receptacle… (SmartThingsCommunity#2784) * Added support for Eaton Master Switch [DEVC-567] and Eaton Receptacle [DEVC-569] to generic z-wave switch DTH. * Reduced code duplication, reverted changes to updateDataValue() calls, removed trailing space from deviceJoinName. * [DEVC-582] Eaton Appliance Plug-In Module integration * ICP-3834 DVCSMP-3634 Update Flags for legacy locally-executing devices (SmartThingsCommunity#2836) * ICP-3834 Update Flags for legacy locally-executing devices * DVCSMP-3634 Add Zigbee valve and Cooper RF9500 local execution flags * Added support for Eaton RF Dimmers (SmartThingsCommunity#2776) * Added support for Eaton RF Dimmers * Removed accessory dimmer support. Minor refactoring. * Reverted changes to updateDataValue() calls. * [DEVC-581] Support for Eaton Plug-In Dimming Module, better configuration for local execution, poll() changes suggested in PR SmartThingsCommunity#2784 by Duncan. * [DEVC-581] Fix for device join name. * Add executeCommandsLocally flag to legacy locally executing DTHs Just default the value to `false` to match the current behavior. * Fixing Compilation error (SmartThingsCommunity#2847)
norrisj44
added a commit
to norrisj44/SmartThingsPublicFork
that referenced
this pull request
Mar 18, 2018
* Remove unused polling capabilities * [DVCSMP-3377] Schlage Locks - For some locks DTH is assigning default code name instead of code name provided by user. * DVCSMP-3283 Adding blacklisted DTH to catch bad devices (SmartThingsCommunity#2371) * DVCSMP-3283 Adding blacklisted DTH to catch bad devices * Adding correct support link * Added curb bridge to smartthingspublic (SmartThingsCommunity#2346) * Added curb bridge to smartthingspublic * untabified, appsettings used * switched to 1 minute interval * took out historical data * took out a rouge } * Added Energy Monitor with load controller and thermostat controls * added historical again, added refresh tokens, added better state restore logic * switches intelligently generate default values * syntax error * typo * it works! * fixed the error messages popping up in the live logging window * added 1m resolution, got rid of erraneous error messages * took out unnecessary debug messages * added all the different energy timeintervals * finishing touches on the curb app * Took out a debug statement * reduced api endpoints to only have single power/energy values * tabs to spaces * fixed atomicstate looping * DVCSMP-3384 Add tile type to multi attribute tile for devices * Add the runLocally flag to Z-Wave Generic DTHs * DVCSMP-3374 Zen Thermostat has no settings for "Heat only" or "Cool only" (SmartThingsCommunity#2503) A customer reported on PR 2296; "My Zen can only Heat (10A setting I think). There is no option for "Off, Heat" in the thermostat modes settings UI." Adding ["off", "heat"] and ["off", "cool"] to settings. * DVCSMP-3283 - Blacklisted Device Link to Support fingerprints install * DVCSMP-690 (SmartThingsCommunity#2483) * DVCSMP-690 Aeon multisensor improvements * Removes the configure tile. * Configuration commands should now be sent on wake-up, until a temperature report is sent * Added preferences to configure the motion timeout and the reporting interval. Defaults are 20s and 5min * Send an association remove during configuration to prevent double reports * Removes the battery from the sensor reporting group. It now reports every 12 hours * Renamed/reworked preferences to more closely match aeon-multisensor-6 * Configuration will now happen on preference update or wakeup if it hasn't happened yet * Added some extra description text to the configuration preferences. * [ICP-2233] During scanning of Lock Codes, Recently tab shows multiple events for added lock codes. * DVCSMP-2220 Aeon Siren not sending alert on secure inclusion failure (SmartThingsCommunity#2511) This just cribs the way other secure devices handle this failure. In the future we'd like to have this standardized or done automatically. * [DVCSMP-3396] Locks DTH should generate event for changed and unset during scanning. * ICP-2082: Set initial state of Z-Wave Switch Generic * Adding changeable icons back to zwave-relay and momentary-button-tile DTHs In a recent update to change these DTHs to use multi-attribute tiles the option to change the device icon for them was lost. This has caused a few users to not be able to change icons on devices that they could before (PROB-1904). This change adds back the ability to change the icons for these two device types. * ICP-2151, ICP-2236, ICP-2237 Add Samsung Lock fingerprint to DTH Give generic name to handle different locks with the same fingerprint * [DVCSMP-2677] Change in DTH for device join name to reflect Aeotec from Aeon Labs * DVCSMP-690 Aeon multisensor improvements (SmartThingsCommunity#2549) * DVCSMP-690 Aeon multisensor improvements Fixes major oversight where commands would not be handled. * DVCSMP-690 Aeon multisensor improvements Bundles configuration and wakeup commands into one multiAction * [ICP-2350], [ICP-2309]: Yale Keyless Connected Smart Door Lock pair as Z-Wave Lock. Yale YRD216 Lock pair as Z-Wave Lock. * SAPLAT-81 Additional fingerprint for Inovelli 2-channel smart plug * ICP-2151, ICP-2236, ICP-2237 *READD* Samsung Digital Lock fingerprint Add comments to fingerprint list breaking out fingerprints by manufacturer for readability Update README with added models * DVCSMP-3412 Utilize sunrise/sunsetTime instead of external API * Revert "DVCSMP-690 Aeon multisensor improvements (SmartThingsCommunity#2549)" This reverts commit 5ee4cec. * Revert "DVCSMP-690 (SmartThingsCommunity#2483)" This reverts commit 4619c13. * Mark 0.20.X devices to run locally This is marking the hubcore 0.20.X newly supported devices to run locally. This resolves: https://smartthings.atlassian.net/browse/CHAD-1633 * Add mfr fingerprints to Fibaro Motion NVS-6 * DVCSMP-3349 Use old reporting logic for older firmware Centralite sensors * Update zigbee fingerprints for sengled Add Sengled E12-N15 to zigbee dimmer DTH Reorder zigbee fingerprinting lines alphanumerically. * NQA-793 - Thermostat automation support (SmartThingsCommunity#2614) Small typos small change * DVCSMP-1524 Remove polling capability from hub-polled devices (SmartThingsCommunity#2510) Removes the deprecated polling capability from these devices which are polled by the hub directly. * Add Sengled RGBW to zigbee-rgbw-bulb.groovy * Update deviceJoinName for zigbee-rgbw-bulb.groovy * [DVCSMP-3494] Some schlage locks read "Unlocked by Master Code" when unlocked with a user code. * Dvcsmp-1437 GE Fan switches don't support configuration (SmartThingsCommunity#2626) * DVCSMP-1437 GE Fan switches don't support indicator LED control Move the GE Fan switch to the generic dimmer handler, since they don't support the configuration options of the other GE dimmers. * ICP-1827 Yale Assure Lock device join name fix (SmartThingsCommunity#2630) The two models of Yale Assure Lock (w/ and w/o BT) are indistinguishable based on ZWave info. This makes the name applicable to both models. * Add Sengled Element Plus to zigbee-white-color-temperature-bulb * Honeywell dimmer and switch fingerprints (SmartThingsCommunity#2631) WWST-159 WWST-155 WWST-164 WWST-157 WWST-166 WWST-158 WWST-156 WWST-165 WWST-160 WWST-167 WWST-170 Add fingerprints for Honeywell dimmers and switches. WWST-162 Dimmer switches also not polling for initial status This adds an initial poll on install like we have for (non-dimmer) zwave switches. * PROB-1940 Ecobee Thermostat Automation Setpoint off by 1 Degree When an automation sends a setpoint to an ecobee thermostat that matches the current setpoint, the setpoint changes by 1 degree. This issue was caused by the need of forcing the new setpoint +-1° when rounding issues between °F and °C caused the setpoint to remain the same when changing it manually one step at a time. Added fix to check if setpoints are set manually or by automation before applying the +-1° adjustment. Also added possibility to change the deadband used in device settings. * DVCSMP-1437 GE Fan switch does not support configuration (SmartThingsCommunity#2638) Fixes typo in model number. * [ICP-1827] YALE 256 - Device pairing name is wrong. (SmartThingsCommunity#2640) * WWST-159 WWST-155 WWST-164 WWST-157 WWST-166 WWST-158 WWST-156 WWST-165 WWST-160 WWST-167 (SmartThingsCommunity#2643) Honeywell binary switched were put in the wrong DTH. Should go in the generic one instead of the one meant for GE devices. * ICP-2367 Yale Locks send lock operations before notification events (SmartThingsCommunity#2627) * ICP-2367 Yale Locks send lock operations before notification events We need to enforce the order of notification and lock in order to get the most information possible for the lock/unlock events. This attempts to delay the lock command event until after the notification event. Because if isStateChange, the lock event will actually essentially get ignored as long as the notification event comes. This should delay the calling of createEvent on the doorLockOperation data so that the isStateChange flag should be set how we expect it to be. Cleaning up some of the code and adding a debug log for this rare event. * ICP-2506 Yale has fixed their battery reporting Adds a specific model check for older Yale devices that report their battery values incorrectly. * [CHAD-1649] Temporary Fix to clear tamper * Tamper is cleared after 10s of it being detected This is because tamper is not handled locally * ICP-2750 - State after cutting off power 2** check * Changes made as per the ticket * ICP-2947 - HOTFIX - Remove invalid token Update Update2 * PROB-1869 Zen thermostat connecting with no battery state (SmartThingsCommunity#2671) * PROB-1869 Zen thermostat connecting with no battery state Changing algorithm for calculating battery % so it no longer need the check for upper/lower limit of the received voltage. * Update zen-thermostat.groovy * GWWST-139 Inaccuracy in color temp due to unit conversion/rounding (SmartThingsCommunity#2691) * GWWST-139 Inaccuracy in color temp due to unit conversion/rounding This changes the math to round instead of truncate, which mirrors the operation in appengine-zigbee and local execution and should get us slightly more accurate numbers. * Remove Simulated devices from running locally As a part of the customer beta we ran into a number of different issues with regards to simulated switches running locally. We have decided to remove them from running locally in 20.X and target 21.X which may use this, or a different DTH after discussing options. * ICP-2954 Fingerprints for Yale Conexis (SmartThingsCommunity#2707) * ICP-2954 Fingerprints for Yale Conexis * ICP-2750 - State after cutting off power 2.0 Update * [LSD-204] Adding pausable and usesThirdPartyAuthentication to SmartApp definitions * ICP-2261 - LIFX translated (SmartThingsCommunity#2724) Update * ICP-2850 Setting color temperature causes offline device to come online (SmartThingsCommunity#2729) The event generated by setting the color name is causing devices to be marked online. Changes the zll rgbw bulb to match the zigbee rgbw bulb in terms of how it handles color temperature. * GWWST-84 Fibaro Flood Sensor reports fractional temp (SmartThingsCommunity#2733) Just overwriting the precision from this device to force it to be an integer to match other devices. * DVCSMP-2959: Fibaro Door/Window 2 onboarding Updated some event values for consistency with other Fibaro DTH Changed some code style to also match other Fibaro DTH Added initial state events Set logging enabled by default ICP-2763 Fibaro Door/Window 2 does not go offline: The checkInterval was only being set if the device received a wakeup notification. If the batteries were removed before the first wakeup (i.e. before device configuration) there would be no checkInterval set. * DVCSMP-2807 GWWST-77: Z-Wave Metering Switch (Secure) for support for the Fibaro Smart Switch ZW5 (SmartThingsCommunity#2353) * [DVCSMP-3320]. Support for light bulbs. (SmartThingsCommunity#2439) * DVCSMP-3320. Support for light bulbs. * DVCSMP-3320. Removing profileId from fingerprint. * [LSD-203] Adding CO2 Vent to set flags on the definitions * PROB-1941 Smart Care apps missing Save button on iOS (SmartThingsCommunity#2737) The definition for the page in the preferences section did not specify 'install: true', instead this was specified in the declaration for the dynamicPage. However, it seems changing the definition in the dynamic page declaration doesn't matter as in iOS it always uses the first declaration found. Fixing this issue by adding 'install: true' to the preference declaration and removing the page definition from dynamicPage. * ICP-3086 remove SMS option * ICP-2939 Initial battery poll being ignored (SmartThingsCommunity#2721) This is purely a timing issue caused by secure commands creating a bit of a logjam. This is the lowest value that SR-Pol was reliably able to get a battery report with. * DVCSMP-2874 Aeon multisensor 6 missing method exception (SmartThingsCommunity#2604) Bundles configuration and wakeup commands into one multiAction Changes the checkInterval to match the user-set report interval. Changes ping to use temperature as ping will only work when the device is on ac power, so a battery poll would be not as useful. Changes the checkinterval update to happen inside configure in cases where the device is in wakeup mode so that we don't change the check interval without changing the report interval. Fixes a typo in the time lookup table. * IPB-272 - Door knocker to Spanish * [CHAD-1649] Temporary Fix to clear tamper * Tamper is cleared after 10s of it being detected This is because tamper is not handled locally * ICP-3087 YRD 216 Zigbee missing device fingerprints (SmartThingsCommunity#2739) * ICP-3086 remove SMS option (fixes) * ICP-3135 Wrong icon type for smart plug in SC (SmartThingsCommunity#2747) the switch device type gets a switch icon, but this is a plug so it needs the plug icon * ICP-2818 Sengled bulbs pair at level "1" as well Adding 'sengled' to the list of manufacturers for which we fabricate a level 100 report on add. * PROB-1987 Fix tile type * ICP-3189: Add OSRAM SMART+ Plug fingerprint While this device is a ZLL device, it does work with the ZHA DTH. * Fix exception in Z-Wave fallback types DVCSMP-3560 * ONEAPP-1122 zigbee RGB bulb missing ocf icon (SmartThingsCommunity#2765) * Revert "DVCSMP-3412 Utilize sunrise/sunsetTime instead of external API" This reverts commit 787ef7d. * Variable not defined for CT command * ICP-3342 - Remove SMS * Adds privileged: true Add dynamic pages * DEVC-574 Reduce color temp steps to 50 Kelvin * reduced step size from 500K to 50K. * PROB-1226 - Re authenticate account * DVCSMP-3566 Remove blacklisted Kwikset Smartcode lock (SmartThingsCommunity#2789) * Fingerprints for directly connected Hue lights (SmartThingsCommunity#2787) Although not officially certified or supported many users connect Hue lights directly to the SmartThings hub and most of the type they join as Things. This adds fingerprints for most of the models listed in: https://developers.meethue.com/documentation/supported-lights. https://smartthings.atlassian.net/browse/DVCSMP-3567 * PROB-1824: Add more LEDVANCE/OSRAM/SYLVANIA products (SmartThingsCommunity#2785) * ICP-3342 - Fix dynamic page * Rolling up staging to production (SmartThingsCommunity#2798) * Fix exception in Z-Wave fallback types DVCSMP-3560 * ONEAPP-1122 zigbee RGB bulb missing ocf icon (SmartThingsCommunity#2765) * ICP-3342 - Remove SMS * Adds privileged: true Add dynamic pages * DEVC-574 Reduce color temp steps to 50 Kelvin * reduced step size from 500K to 50K. * PROB-1824: Add more LEDVANCE/OSRAM/SYLVANIA products (SmartThingsCommunity#2785) * ICP-3342 - Fix dynamic page * [LSD-204] Adding definition flags to IFTTT (SmartThingsCommunity#2800) * DVCSMP-3566 Adding profile id for kwikset locks (SmartThingsCommunity#2791) * Report correct status when locked via keypad (SmartThingsCommunity#2781) Schlage and Yale, with One Touch locking enabled are locked manually from the keypad, report the status correct to differentiate manual locking and keypad locking * Provide new virtual switches for local execution (SmartThingsCommunity#2807) This adds a pair of new Virtual Switch device types that can execute locally. This allows us to avoid breaking existing functionality while providing exactly the functionality that we want. * ICP-3154 Locks not responsive in Poland (SmartThingsCommunity#2809) Similar to the battery change a month ago, command backups were causing commands to be sent to quickly to Yale locks, causing them to get wedged. * Add support for 0.21.X locally running devices (SmartThingsCommunity#2812) This is a part of: https://smartthings.atlassian.net/browse/CHAD-1389 * MKTP-1186 - SendEvent Switch to support SC (SmartThingsCommunity#2813) * PROB-1824 Add newer LEDVANCE Sylvania BR30 and RT5/6 tunable white (SmartThingsCommunity#2810) * SAPLAT-96 Virtual Device Manager to create virtual devices from the app (SmartThingsCommunity#2808) * SAPLAT-96 Virtual Device Manager to create virtual devices from the app * SAPLAT-96 SingleInstace param for smartapp missing (SmartThingsCommunity#2822) * Modified runCall function * DVCSMP-3412 Restore the code change to Sunrise/Sunset * DVCSMP-3298 Add state labels to Fibaro sensors that were missing them. (SmartThingsCommunity#2832) * Add fingerprint for Sengled RGBW (SmartThingsCommunity#2825) DVCSMP-3503 Add fingerprint for Sengled RGBW * Added UV Capability, humidity icon, sync time stamp * Remove Humidity icon (for iOS) * WWST-131 Added fingerprint Aeotec Smart Dimmer 6 * Icp 3837 Add/Update fingerprints for Ikea TRÅDFRI Smart Bulbs (SmartThingsCommunity#2837) * ICP-3837 Add/Update fingerprints for Ikea TRÅDFRI Smart Bulbs Whitespace conversion from spaces to Tabs Ikea bulbs deviceJoinName changes Add 3 new fingerprint for Ikea bulbs * Added support for Eaton Master Switch [DEVC-567] and Eaton Receptacle… (SmartThingsCommunity#2784) * Added support for Eaton Master Switch [DEVC-567] and Eaton Receptacle [DEVC-569] to generic z-wave switch DTH. * Reduced code duplication, reverted changes to updateDataValue() calls, removed trailing space from deviceJoinName. * [DEVC-582] Eaton Appliance Plug-In Module integration * ICP-3834 DVCSMP-3634 Update Flags for legacy locally-executing devices (SmartThingsCommunity#2836) * ICP-3834 Update Flags for legacy locally-executing devices * DVCSMP-3634 Add Zigbee valve and Cooper RF9500 local execution flags * Added support for Eaton RF Dimmers (SmartThingsCommunity#2776) * Added support for Eaton RF Dimmers * Removed accessory dimmer support. Minor refactoring. * Reverted changes to updateDataValue() calls. * [DEVC-581] Support for Eaton Plug-In Dimming Module, better configuration for local execution, poll() changes suggested in PR SmartThingsCommunity#2784 by Duncan. * [DEVC-581] Fix for device join name. * Add executeCommandsLocally flag to legacy locally executing DTHs Just default the value to `false` to match the current behavior. * Fixing Compilation error (SmartThingsCommunity#2847) * Prevent spurious device delete & recreate (SmartThingsCommunity#2850) If LIFX API doesn’t return a 200 response when querying devices in a location, we returned an empty list which led us to delete all devices. Those that were part of a SmartApp could not be removed, and did not churn as such. Now we: * Throw a RuntimeException if not a 200 response - causes SA to error out instead of deleting devices * do not force delete devices when using Cirrus - this would have exacerbated the problem Other changes: * Move to spaces for indent (indenting was inconsistent) * DVCSMP-3535 Add battery metric logging (SmartThingsCommunity#2829) * WWST-131 Move Aeotec Smart Dimmer 6 to metering dimmer (SmartThingsCommunity#2861) * ICP-3774 Update pingable contact sensors to poll status (SmartThingsCommunity#2828) * ICP-3774 Update pingable contact sensors to poll status As a stop-gap before a more robust solution to offline state change mismatches, we'll now ping contact sensors for their contact state instead of for battery or temperature. Add motion sensor. * ICP-3846 Ecobee Sensor's temperature is missing "units" (SmartThingsCommunity#2862) Adding unit to temperature event and changing invalid value "--" for "unknown" to 0 as temperature is of type NUMBER. * Fix for handler sending incorrect basic set values (SmartThingsCommunity#2658) According to Z-Wave documentation Basic Set and MultiLevel set accept values with the range of 0,1..99 (0x01..0x63), & 255. The slider in this handler can be set to 100 and there was no input checking in the setLevel method. This is causing the handler to send an invalid value of 100 to the device and several devices are not responding to the command. This change is code taken from the SmartThings "Dimmer Switch" device handler. It merely checks the setLevel input value to make sure it is a valid value. If it is less than 0 it sends 0 if it is greater than 99 it sends 99. * Add usage information for virtual device creator (SmartThingsCommunity#2873) This adds some additional information to the preferences page for the virtual device manager to explain what the different actions will do. * [DEVC-587] Add fingerprint for Dome Z-Wave Door & Window sensor DMWD1 to generic Z-Wave Plus Door Window Sensor DTH. (SmartThingsCommunity#2870) * [DEVC-587] Initial commit - formatting. * [DEVC-587] Add fingerprint for Dome Z-Wave Door & Window sensor DMWD1 to generic Z-Wave Plus Door Window Sensor DTH. * [DEVC-592] Add Coolcam Neo Z-Wave Door/Window sensor NAS-DS02ZU fingerprint to generic Z-Wave Plus Door Window Sensor DTH. (SmartThingsCommunity#2871) * [DEVC-592] Initial commit - formatting. * [DEVC-592] Add Coolcam Neo Z-Wave Door/Window sensor NAS-DS02ZU fingerprint to generic Z-Wave Plus Door Window Sensor DTH. * [DEVC-584] Add support for Dome On-Off Smart Outlet Z52NAS-WR01Z to generic Z-Wave Metering Switch DTH. (SmartThingsCommunity#2869) * [DEVC-584] Initial commit - formatting. * [DEVC-584] Add support for Dome On-Off Smart Outlet Z52NAS-WR01Z to generic Z-Wave Metering Switch DTH. * [DEVC-583] Add Cooolcam NEO Power plug NAS-WR02ZU to generic Z-Wave Metering Switch DTH. (SmartThingsCommunity#2868) * [DEVC-583] Initial commit - formatting. * [DEVC-583] Add support for Cooolcam NEO Power plug NAS-WR02ZU to generic Z-Wave Metering Switch DTH. * ICP-3774 Update contact sensors to be offline pingable (SmartThingsCommunity#2881) * ICP-3774 Update contact sensors to be offline pingable Because DeviceHealth is only going to ping the offlinepingable devices, we need to make these contact sensors offlinepingable. * WWST-201 Add fingerprint for Aeotec Smart Switch 6 * DVCSMP-3412 Restore the code change to Sunrise/Sunset (SmartThingsCommunity#2891) * ONEAPP-1477 - Translations (SmartThingsCommunity#2893) * [DEVC-590] Add Dome Z-Wave Water Detector DMWS1 fingerprint to Z-wave Water Sensor DTH. (SmartThingsCommunity#2877) * [DEVC-590] Initial commit - formatting. * [DEVC-590] Add Dome Z-Wave Water Detector DMWS1 fingerprint to Z-wave Water Sensor DTH. * [DEVC-590] Add health check for Dome Leak Sensor. * [DEVC-586] Add fingerprint for Dome Z-Wave Water Main Shut-off DMWV1 to generic Z-wave water valve DTH. (SmartThingsCommunity#2896) * [DEVC-586] Initial commit - formatting. * [DEVC-586] Add fingerprint for Dome Z-Wave Water Main Shut-off DMWV1 to generic Z-wave water valve DTH. * [DEVC-588] Add support for Dome Z-Wave Siren DMS01 to generic Z-wave Siren DTH. (SmartThingsCommunity#2897) * [DEVC-588] Initial commit - formatting. * [DEVC-588] Add support for Dome Z-Wave Siren DMS01 to generic Z-wave Siren DTH. * [DEVC-593] Add implementation for Coolcam Neo Z-Wave Siren NAS-AB02ZU to generic Z-wave Siren DTH. (SmartThingsCommunity#2884) * [DEVC-593] Initial commit - formatting. * [DEVC-593] Add implementation for Coolcam Neo Z-Wave Siren NAS-AB02ZU to generic Z-wave Siren DTH. * Set Aeon Minimote Child buttons hub (SmartThingsCommunity#2874) Previously these child devices were not associated with a hub. As a result the information about the child devices weren't synced locally. This prevented us from being able to generate events for those child devices. This is a part of: https://smartthings.atlassian.net/browse/DVCSMP-3277 * PROB-2014 Fix issue with after schedules being overwritten * DVCSMP-3664 Fix most common exceptions (SmartThingsCommunity#2911) * DVCSMP-3664 Fix most common exceptions Code oversight in Z-Wave Controller. Essentially an NPE in aeon home energy meter. * DVCSMP-3657 SmartSense Garage Door Multi Sensor not detecting closed garage door (SmartThingsCommunity#2902) Removed checking x/y axes and increased open threshold. Also remove x/y accel data from log * Make generic switch cloud DTH match LEE version (SmartThingsCommunity#2835) * If we genericize the generic switch DTH (and make it match local execution implementation) we should be able to get the Eaton accessory dimmer to fit without any changes. * ICP-3956 Smoke sensor pairing without configuring (SmartThingsCommunity#2914) Updates the "secure" detection method to be more in line with modern practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the math to round instead of truncate, which mirrors the operation in appengine-zigbee and should get us slightly more accurate numbers.