Skip to content

GWWST-139 Inaccuracy in color temp due to unit conversion/rounding #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2018
Merged

GWWST-139 Inaccuracy in color temp due to unit conversion/rounding #2691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71e2abe
GWWST-139 Inaccuracy in color temp due to unit conversion/rounding
greens Jan 11, 2018
702229d
GWWST-139 Inaccuracy in color temp due to unit conversion/rounding
greens Jan 11, 2018
9d806bb
Revert "GWWST-139 Inaccuracy in color temp due to unit conversion/rou…
greens Jan 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devicetypes/smartthings/zigbee-rgbw-bulb.src/zigbee-rgbw-bulb.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def configure() {
def setColorTemperature(value) {
setGenericName(value)
value = value as Integer
def tempInMired = (1000000 / value) as Integer
def tempInMired = Math.round(1000000 / value)
def finalHex = zigbee.swapEndianHex(zigbee.convertToHexString(tempInMired, 4))

zigbee.command(COLOR_CONTROL_CLUSTER, 0x0A, "$finalHex 0000") +
Expand Down
2 changes: 1 addition & 1 deletion ...things/zigbee-white-color-temperature-bulb.src/zigbee-white-color-temperature-bulb.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def configure() {
def setColorTemperature(value) {
setGenericName(value)
value = value as Integer
def tempInMired = (1000000 / value) as Integer
def tempInMired = Math.round(1000000 / value)
def finalHex = zigbee.swapEndianHex(zigbee.convertToHexString(tempInMired, 4))

List cmds = []
Expand Down
2 changes: 1 addition & 1 deletion .../zll-white-color-temperature-bulb-5000k.src/zll-white-color-temperature-bulb-5000k.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def updated() {
def setColorTemperature(value) {
setGenericName(value)
value = value as Integer
def tempInMired = (1000000 / value) as Integer
def tempInMired = Math.round(1000000 / value)
def finalHex = zigbee.swapEndianHex(zigbee.convertToHexString(tempInMired, 4))

zigbee.command(COLOR_CONTROL_CLUSTER, MOVE_TO_COLOR_TEMPERATURE_COMMAND, "$finalHex 0000") +
Expand Down
2 changes: 1 addition & 1 deletion .../smartthings/zll-white-color-temperature-bulb.src/zll-white-color-temperature-bulb.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def updated() {
def setColorTemperature(value) {
setGenericName(value)
value = value as Integer
def tempInMired = (1000000 / value) as Integer
def tempInMired = Math.round(1000000 / value)
def finalHex = zigbee.swapEndianHex(zigbee.convertToHexString(tempInMired, 4))

zigbee.command(COLOR_CONTROL_CLUSTER, MOVE_TO_COLOR_TEMPERATURE_COMMAND, "$finalHex 0000") +
Expand Down