GWWST-139 Inaccuracy in color temp due to unit conversion/rounding

Based on feedback, product would prefer if we fudged the numbers a bit so that K values match what is set by the user.

Author: greens

devicetypes/smartthings/zigbee-rgbw-bulb.src/zigbee-rgbw-bulb.groovy

@@ -94,6 +94,12 @@ def parse(String description) {
         if (event.name=="level" && event.value==0) {}
         else {
             if (event.name=="colorTemperature") {
+                // Because of conversion to and from mireds we get some accuracy loss so in order for UI
+                // elements to match commands, we'll just see if they're within a tolerance
+                if (event.value <= state.lastValue * 1.05 && event.value >= state.lastValue * .95) {
+                    event.value = state.lastValue
+                    state.lastValue = null
+                }
                 setGenericName(event.value)
             }
             sendEvent(event)
@@ -174,6 +180,8 @@ def setColorTemperature(value) {
     def tempInMired = Math.round(1000000 / value)
     def finalHex = zigbee.swapEndianHex(zigbee.convertToHexString(tempInMired, 4))
 
+    state.lastLevel = value
+
     zigbee.command(COLOR_CONTROL_CLUSTER, 0x0A, "$finalHex 0000") +
     zigbee.readAttribute(COLOR_CONTROL_CLUSTER, ATTRIBUTE_COLOR_TEMPERATURE)
 }

devicetypes/smartthings/zigbee-white-color-temperature-bulb.src/zigbee-white-color-temperature-bulb.groovy

@@ -94,6 +94,12 @@ def parse(String description) {
         if (event.name=="level" && event.value==0) {}
         else {
             if (event.name=="colorTemperature") {
+                // Because of conversion to and from mireds we get some accuracy loss so in order for UI
+                // elements to match commands, we'll just see if they're within a tolerance
+                if (event.value <= state.lastValue * 1.05 && event.value >= state.lastValue * .95) {
+                    event.value = state.lastValue
+                    state.lastValue = null
+                }
                 setGenericName(event.value)
             }
             sendEvent(event)
@@ -169,6 +175,7 @@ def setColorTemperature(value) {
         cmds << zigbee.command(COLOR_CONTROL_CLUSTER, MOVE_TO_COLOR_TEMPERATURE_COMMAND, "$finalHex 0000")
     }
     cmds << zigbee.readAttribute(COLOR_CONTROL_CLUSTER, ATTRIBUTE_COLOR_TEMPERATURE)
+    state.lastLevel = value
     cmds
 }
 

devicetypes/smartthings/zll-white-color-temperature-bulb-5000k.src/zll-white-color-temperature-bulb-5000k.groovy

@@ -78,6 +78,13 @@ def parse(String description) {
     if (event) {
         if (event.name == "colorTemperature") {
             event.unit = "K"
+            // Because of conversion to and from mireds we get some accuracy loss so in order for UI
+            // elements to match commands, we'll just see if they're within a tolerance
+            if (event.value <= state.lastValue * 1.05 && event.value >= state.lastValue * .95) {
+                event.value = state.lastValue
+                state.lastValue = null
+            }
+            setGenericName(event.value)
         }
         sendEvent(event)
     }
@@ -157,6 +164,8 @@ def setColorTemperature(value) {
     def tempInMired = Math.round(1000000 / value)
     def finalHex = zigbee.swapEndianHex(zigbee.convertToHexString(tempInMired, 4))
 
+    state.lastLevel = value
+
     zigbee.command(COLOR_CONTROL_CLUSTER, MOVE_TO_COLOR_TEMPERATURE_COMMAND, "$finalHex 0000") +
     zigbee.readAttribute(COLOR_CONTROL_CLUSTER, ATTRIBUTE_COLOR_TEMPERATURE)
 }

devicetypes/smartthings/zll-white-color-temperature-bulb.src/zll-white-color-temperature-bulb.groovy

@@ -79,6 +79,15 @@ def parse(String description) {
     log.debug "description is $description"
     def event = zigbee.getEvent(description)
     if (event) {
+        if (event.name=="colorTemperature") {
+            // Because of conversion to and from mireds we get some accuracy loss so in order for UI
+            // elements to match commands, we'll just see if they're within a tolerance
+            if (event.value <= state.lastValue * 1.05 && event.value >= state.lastValue * .95) {
+                event.value = state.lastValue
+                state.lastValue = null
+            }
+            setGenericName(event.value)
+        }
         sendEvent(event)
     }
     else {
@@ -153,6 +162,8 @@ def setColorTemperature(value) {
     def tempInMired = Math.round(1000000 / value)
     def finalHex = zigbee.swapEndianHex(zigbee.convertToHexString(tempInMired, 4))
 
+    state.lastLevel = value
+
     zigbee.command(COLOR_CONTROL_CLUSTER, MOVE_TO_COLOR_TEMPERATURE_COMMAND, "$finalHex 0000") +
     zigbee.readAttribute(COLOR_CONTROL_CLUSTER, ATTRIBUTE_COLOR_TEMPERATURE)
 }