-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Points out that outputFileSystem needs of methods #1265
Conversation
OTOH, Should webpack auto make the polyfills if someone set an @sokra have a miunte to give opinions? |
the `mkdirp` and `join` are also needed by `outputFileSystem`.
no, they could be different for each fs. |
https://travis-ci.org/webpack/webpack.js.org/builds/238324866#L746 Can't pass travis CI check caused by this link is 404: http://cssnano.co/options/ . |
@mc-zone just opened a pull request (webpack-contrib/css-loader#550) to resolve this. css-loader's readme is dynamically pulled into this repo and the broken link was there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor wording change, aside from that this should be good to go (we don't have to wait on the css-loader pr).
content/api/node.md
Outdated
@@ -277,4 +277,4 @@ compiler.run((err, stats) => { | |||
}); | |||
``` | |||
|
|||
T> The output file system you provide needs to be compatible with Node’s own [`fs`](https://nodejs.org/api/fs.html) module interface. | |||
T> The output file system you provide needs to be compatible with Node’s own [`fs`](https://nodejs.org/api/fs.html) module interface, and other two helper methods `mkdirp`, `join` are also needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be better as:
module interface, which requires the `mkdirp` and `join` helper methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Got it.
the
mkdirp
andjoin
are also needed byoutputFileSystem
.