docs(README): fix broken link #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cssnano.co/options/ is currently a 404 as it looks like they changed their routing structure. This was throwing broken link errors on webpack.js.org as we dynamically pull this readme.
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 10 10
Lines 367 367
Branches 87 87
=======================================
Hits 362 362
Misses 5 5Continue to review full report at Codecov.
|
michael-ciniawsky
changed the title
michael-ciniawsky
approved these changes
Jun 2, 2017
README.md
Outdated
| @@ -342,7 +342,7 @@ To import from multiple modules use multiple `composes:` rules. | |||
|
|
|||
| By default the css-loader minimizes the css if specified by the module system. | |||
|
|
|||
| In some cases the minification is destructive to the css, so you can provide your own options to the minifier if needed. cssnano is used for minification and you find a [list of options here](http://cssnano.co/options/). | |||
| In some cases the minification is destructive to the css, so you can provide your own options to the cssnano-based minifier if needed. See [cssnano's documenation](http://cssnano.co/guides/) for more information on the available options. | |||
|
|
|||
There was a problem hiding this comment.
documenation => documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
readme fix
Did you add tests for your changes?
no
If relevant, did you update the README?
yes
Summary
cssnano.co/options/ is currently a 404 as it looks like they changed their routing
structure. This was throwing broken link errors on webpack.js.org as we dynamically
pull this readme.
Does this PR introduce a breaking change?
no