Add namespace check of svg & mathML instead of tag names #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
changed the title
mysticatea
reviewed
Aug 2, 2017
lib/utils/index.js
Outdated
| */ | ||
| isHtmlElementName (name) { | ||
| assert(typeof name === 'string') | ||
| isHtmlElementNode (node) { |
There was a problem hiding this comment.
Thank you for good change.
However, it might cause confusing if isHtmlElementNode is not checking their namespace but isSvgElementNode and isMathMLElementNode are checking their namespace. How about renaming to isKnownHtmlElementNode?
There was a problem hiding this comment.
@mysticatea I think we should add namespace check to it to... <a> can be in both HTML and SVG
There was a problem hiding this comment.
@armano2 Oh, good catch! Also <style> and <script> exist in SVG.
add namespace check for html
filipalacerda
pushed a commit
to filipalacerda/eslint-plugin-vue
that referenced
this pull request
Aug 5, 2017
* master: Add rule `vue/require-valid-default-prop`. (vuejs#119) 3.10.0 Update readme to 3.10.0 Chore: remove package-lock.json (vuejs#128) Fix: parserService must exist always (fixes vuejs#125) (vuejs#127) Add rule `require-render-return`. (vuejs#114) 3.9.0 Update package-lock Update: options for `no-duplicate-attributes` (fixes vuejs#112)(vuejs#113) New: add rule `attribute-hyphenation`. (fixes vuejs#92)(vuejs#95) Add namespace check of svg & mathML instead of tag names (vuejs#120)⚠️ Add support for deprecated state in update-rules⚠️ (vuejs#121) Add rules: `no-dupe-keys` and `no-reserved-keys`. (vuejs#88) Chore: Improve tests for name-property-casing & improve documentation (vuejs#115) New: add `require-prop-types` rule (fixes vuejs#19)(vuejs#85) Update: upgrade vue-eslint-parser (fixes vuejs#36, fixes vuejs#56, fixes vuejs#96) (vuejs#116)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
isHtmlElementName(string)isSvgElementName(string)New:
isKnownHtmlElementNode(ASTNode)isSvgElementNode(ASTNode)isMathMLElementNode(ASTNode)and broken / deprecated / unused
getTemplateBodyTokenStoreis removed in this commit