Skip to content

Add documentation for some internal function #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jul 29, 2017

No description provided.

@armano2 armano2 force-pushed the patch-23-add-missing-documentsation branch from 138f849 to 31a1bf9 Compare July 31, 2017 19:29
@michalsnik michalsnik requested a review from mysticatea August 1, 2017 09:20
@armano2 armano2 force-pushed the patch-23-add-missing-documentsation branch from 31a1bf9 to a9aa2bd Compare August 1, 2017 10:27
@@ -83,8 +93,12 @@ ruleTester.run('name-property-casing', rule, {
name: 'foo bar'
}
`,
options: ['PascalCase'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removal intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, PascalCase is set by default and we was missing test case without options set

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you!

@mysticatea mysticatea merged commit e42491f into vuejs:master Aug 1, 2017
@armano2 armano2 deleted the patch-23-add-missing-documentsation branch August 1, 2017 14:03
filipalacerda pushed a commit to filipalacerda/eslint-plugin-vue that referenced this pull request Aug 5, 2017
* master:
  Add rule `vue/require-valid-default-prop`. (vuejs#119)
  3.10.0
  Update readme to 3.10.0
  Chore: remove package-lock.json (vuejs#128)
  Fix: parserService must exist always (fixes vuejs#125) (vuejs#127)
  Add rule `require-render-return`. (vuejs#114)
  3.9.0
  Update package-lock
  Update: options for `no-duplicate-attributes` (fixes vuejs#112)(vuejs#113)
  New: add rule `attribute-hyphenation`. (fixes vuejs#92)(vuejs#95)
  Add namespace check of svg & mathML instead of tag names (vuejs#120)
  ⚠️ Add support for deprecated state in update-rules ⚠️ (vuejs#121)
  Add rules: `no-dupe-keys` and `no-reserved-keys`. (vuejs#88)
  Chore: Improve tests for name-property-casing & improve documentation (vuejs#115)
  New: add `require-prop-types` rule (fixes vuejs#19)(vuejs#85)
  Update: upgrade vue-eslint-parser (fixes vuejs#36, fixes vuejs#56, fixes vuejs#96) (vuejs#116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants