Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vincentbel/react-javascript-to-typescript-transform
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: lyft/react-javascript-to-typescript-transform
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 22 files changed
  • 4 contributors

Commits on Feb 5, 2018

  1. Upgrade to TypeScript 2.7 (lyft#34)

    @mohsen1
    mohsen1 authored Feb 5, 2018
    Configuration menu
    Copy the full SHA
    23cdac4 View commit details
    Browse the repository at this point in the history

  2. Avoid repeated state type members (lyft#22)

    @mohsen1
    mohsen1 authored Feb 5, 2018
    Configuration menu
    Copy the full SHA
    1e17c1b View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2018

  1. Keep other static class members, such as defaultProps (lyft#36) 

    * Add test for defaultProps

* Check if the name == "propTypes", not != " propTypes"

* More ways of getting the class member name (hacky)

* Check if we're an identifier; if we are we can just always use name.escapedText

* Use ts.isIdentifier helper function instead of direct comparison on .kind
    @mohsen1
    Athena Yao authored and mohsen1 committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    a2338d9 View commit details
    Browse the repository at this point in the history

  2. v1.4.0

    Mohsen Azimi committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    3f11a66 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2018

  1. Update README.md

    @mohsen1
    mohsen1 authored Apr 7, 2018
    Configuration menu
    Copy the full SHA
    abbbb57 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2018

  1. Update dependencies (lyft#42) 

    * Update dependencies
    @mohsen1
    mohsen1 authored May 19, 2018
    Configuration menu
    Copy the full SHA
    9bd8777 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2018

  1. Safety/QOL fixes (lyft#39) 

    * Build prettier options only once

* Use a temporary file for the transformation

* Add --ignore-prettier-errors option

* Add --keep-*-files options for easier debugging

* Exit with error code 1 when there were compilation errors

* Fix multiple file/glob parameters

Refs lyft#31

Refs lyft#37

* Add progress message
    @akx @mohsen1
    akx authored and mohsen1 committed May 20, 2018
    Configuration menu
    Copy the full SHA
    3b91d88 View commit details
    Browse the repository at this point in the history
Loading